Skip to content

Conversation

@danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Dec 2, 2025

Fixes #1998

@danielvegamyhre danielvegamyhre marked this pull request as draft December 2, 2025 00:20
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 2, 2025
@danielvegamyhre danielvegamyhre force-pushed the docmx branch 5 times, most recently from 57b3cf0 to 66c8771 Compare December 2, 2025 16:07
@danielvegamyhre danielvegamyhre marked this pull request as ready for review December 2, 2025 16:08
@danielvegamyhre danielvegamyhre requested a review from vkuzo December 2, 2025 16:08
@danielvegamyhre
Copy link
Contributor Author

cc @vkuzo and @tianyu-l for review.

Copy link
Contributor

@tianyu-l tianyu-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit comments on picture

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe put in the existing assets/images folder

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image looks very blurry, not sure why. If possible could you find a more clear version? Fine if not.

Copy link
Contributor Author

@danielvegamyhre danielvegamyhre Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved the image to assets/images. as for the blurriness, it's the same image as in the torchao docs here, where i think it looks reasonably clear: https://github.com/pytorch/ao/tree/main/torchao/prototype/moe_training i'll see if we can get a clearer one though

@danielvegamyhre danielvegamyhre force-pushed the docmx branch 2 times, most recently from 3626393 to 7d68f7f Compare December 3, 2025 04:18
@danielvegamyhre danielvegamyhre merged commit b3da1a2 into pytorch:main Dec 3, 2025
9 checks passed

**Hardware Requirements:**

MXFP8 training requires NVIDIA B200 (SM100) or newer GPUs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we can just say this once, not necessary to repeat multiple times

- torchao version: `0.13.0+gite4e681be`
- torchtitan commit: `6fc499f6f5b32151a799188be2208cfb09faed30`

*Source: [TorchAO MX Formats Benchmarks](https://github.com/pytorch/ao/tree/main/torchao/prototype/mx_formats#training-e2e-benchmarks-on-nvidia-b200)*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: just link to the benchmarks instead of copy-paste, so that it can be updated in just one place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Documentation] [BE] Add docs for MXFP8 training on Blackwell

3 participants