-
Notifications
You must be signed in to change notification settings - Fork 624
[mxfp8] [docs] [BE] add MXFP8 usage documentation and benchmarks #2096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
57b3cf0 to
66c8771
Compare
tianyu-l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit comments on picture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe put in the existing assets/images folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image looks very blurry, not sure why. If possible could you find a more clear version? Fine if not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved the image to assets/images. as for the blurriness, it's the same image as in the torchao docs here, where i think it looks reasonably clear: https://github.com/pytorch/ao/tree/main/torchao/prototype/moe_training i'll see if we can get a clearer one though
3626393 to
7d68f7f
Compare
7d68f7f to
afbb18b
Compare
|
|
||
| **Hardware Requirements:** | ||
|
|
||
| MXFP8 training requires NVIDIA B200 (SM100) or newer GPUs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like we can just say this once, not necessary to repeat multiple times
| - torchao version: `0.13.0+gite4e681be` | ||
| - torchtitan commit: `6fc499f6f5b32151a799188be2208cfb09faed30` | ||
|
|
||
| *Source: [TorchAO MX Formats Benchmarks](https://github.com/pytorch/ao/tree/main/torchao/prototype/mx_formats#training-e2e-benchmarks-on-nvidia-b200)* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: just link to the benchmarks instead of copy-paste, so that it can be updated in just one place
Fixes #1998