Fix 217: Merge function for Qasm Modules #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hey there! It looks like the changelog might need an update. Please take a moment to edit the
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
|
||
| assert "qubit[3] __PYQASM_QUBITS__;" in merged_text | ||
| assert "measure __PYQASM_QUBITS__[2];" in merged_text | ||
| assert "barrier __PYQASM_QUBITS__" in merged_text |
There was a problem hiding this comment.
Suggested change
| assert "barrier __PYQASM_QUBITS__" in merged_text | |
| assert "barrier __PYQASM_QUBITS__[0]" in merged_text |
| merged_text = str(merged) | ||
|
|
||
| assert "qubit[3] __PYQASM_QUBITS__;" in merged_text | ||
| assert "measure __PYQASM_QUBITS__[2];" in merged_text |
There was a problem hiding this comment.
Why are we changing the structure of the measurement statements? I believe the merged qasm should be like -
OPENQASM 3.0;
include "stdgates.inc";
qubit[3] __PYQASM_QUBITS__;
// Module A
bit[1] ca;
h __PYQASM_QUBITS__[0];
barrier __PYQASM_QUBITS__[0];
ca[0] = measure __PYQASM_QUBITS__[0];
// Module B
bit[2] cb;
x __PYQASM_QUBITS__[1];
cb[1] = measure __PYQASM_QUBITS__[1];There was a problem hiding this comment.
Can you use the verification functions from the tests/utils.py file? We have already implemented a lot of robust checks in that file which you are implementing from scratch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes issue 217 by adding a merge function, so two QasmModule objects can be combined into one. The merge function unrolls both modules and creates a single qubit declaration. This function appends the second QasmModule object with the correct index offsets and returns a Qasm3Module.
The test_merge.py file is added, which has a few examples of merging two modules, using the merge function.