Skip to content

fix(VNA-408): hypercube handler path and arguments types #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+346 −377
Open

fix(VNA-408): hypercube handler path and arguments types #1823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41e0671
fix: hypercube handler path with slash
Donya-qlik Oct 16, 2025
3cecd73
fix: add/remove fields is not triggered by the chart
Donya-qlik Oct 28, 2025
2318743
fix: remove the hypercube path condition
Donya-qlik Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apis/conversion/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,6 @@ const conversion = {
hypercube,
};

export { utils, arrayUtil, helpers };
export { utils, arrayUtil, helpers, getPath };

export default conversion;
26 changes: 19 additions & 7 deletions apis/nucleus/src/viz.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable no-underscore-dangle */
import EventEmitter from 'node-event-emitter';
import { convertTo as conversionConvertTo, helpers } from '@nebula.js/conversion';
import { convertTo as conversionConvertTo, helpers, getPath } from '@nebula.js/conversion';
import { HyperCubeHandler } from '@nebula.js/supernova';
import glueCell from './components/glue';
import getPatches from './utils/patcher';
Expand All @@ -11,6 +11,22 @@ import saveSoftProperties from './utils/save-soft-properties';

const noopi = () => {};

const getHandlerPath = (cellRef) => {
const qae = cellRef.current.getQae();
let path = getPath(qae);

if (!path) {
return undefined;
}

const steps = path.split('/');
if (steps.length && steps.indexOf('qHyperCubeDef') > -1) {
path = 'qHyperCubeDef';
}

return path;
};

export default function viz({
model,
halo,
Expand Down Expand Up @@ -120,15 +136,10 @@ export default function viz({
*/
async getHypercubePropertyHandler() {
await rendered;
const qae = cellRef.current.getQae();

if (!qae?.data?.targets?.[0]?.propertyPath) {
return undefined;
}

const path = qae.data.targets[0].propertyPath;
const dataDefinition = cellRef.current.getExtensionDefinition().data;
const properties = await model.getEffectiveProperties();
const path = getHandlerPath(cellRef);

if (path && dataDefinition) {
const args = {
Expand All @@ -140,6 +151,7 @@ export default function viz({
globalChangeListeners: undefined,
path,
};

return new HyperCubeHandler(args);
}

Expand Down
45 changes: 16 additions & 29 deletions apis/supernova/src/handler/__tests__/data-property-handler.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,33 +34,33 @@ describe('DataPropertyHandler', () => {
describe('getDimensions()', () => {
test('should return null when dimension is undefined', () => {
jest.spyOn(handler, 'getDimensions').mockReturnValue([]);
const dimension = handler.getDimension({});
const dimension = handler.getDimension(undefined);
expect(dimension).toBeFalsy();
});

test('should return dimension when it exists in getDimensions()', () => {
jest.spyOn(handler, 'getDimensions').mockReturnValue([{ qDef: { cId: 'dim1' } }]);
jest.spyOn(handler, 'getAlternativeDimensions').mockReturnValue([{ qDef: { cId: 'altDim1' } }]);
const dimension = handler.getDimension({ id: 'dim1' });
const dimension = handler.getDimension('dim1');
expect(dimension).toEqual({ qDef: { cId: 'dim1' } });
const alternativeDimension = handler.getDimension({ id: 'altDim1' });
const alternativeDimension = handler.getDimension('altDim1');
expect(alternativeDimension).toEqual({ qDef: { cId: 'altDim1' } });
});
});

describe('getMeasure()', () => {
test('should return null when both measures and alternative measures are empty', () => {
jest.spyOn(handler, 'getMeasures').mockReturnValue([]);
const measure = handler.getMeasure({});
const measure = handler.getMeasure(undefined);
expect(measure).toBeFalsy();
});

test('should return measure when it exists in getMeasures()', () => {
jest.spyOn(handler, 'getMeasures').mockReturnValue([{ qDef: { cId: 'measure1' } }]);
jest.spyOn(handler, 'getAlternativeMeasures').mockReturnValue([{ qDef: { cId: 'altMeasure1' } }]);

const measure = handler.getMeasure({ id: 'measure1' });
const alternativeMeasure = handler.getMeasure({ id: 'altMeasure1' });
const measure = handler.getMeasure('measure1');
const alternativeMeasure = handler.getMeasure('altMeasure1');
expect(measure).toEqual({ qDef: { cId: 'measure1' } });
expect(alternativeMeasure).toEqual({ qDef: { cId: 'altMeasure1' } });
});
Expand All @@ -74,10 +74,9 @@ describe('DataPropertyHandler', () => {
});

test('should create a dimension with default properties when no field is provided', () => {
const fieldDimension = { field: '', label: '', defaults: { customDefault: 'value' } };
const result = handler.createFieldDimension(fieldDimension);
const result = handler.createFieldDimension(null, null, { customDefault: 'value' });

expect(result.qDef.qFieldDefs).toEqual(['']);
expect(result.qDef.qFieldDefs).toEqual([null]);
expect(result.qDef.qFieldLabels).toEqual(['']);
expect(result.qDef.qSortCriterias).toEqual(sortingProperties);
expect(result.qDef.autoSort).toBe(true);
Expand All @@ -87,8 +86,7 @@ describe('DataPropertyHandler', () => {
});

test('should create a dimension with provided field and label', () => {
const fieldDimension = { field: 'fieldName', label: 'fieldLabel' };
const result = handler.createFieldDimension(fieldDimension);
const result = handler.createFieldDimension('fieldName', 'fieldLabel', { customDefault: 'value' });

expect(result.qDef.qFieldDefs).toEqual(['fieldName']);
expect(result.qDef.qFieldLabels).toEqual(['fieldLabel']);
Expand All @@ -105,8 +103,7 @@ describe('DataPropertyHandler', () => {
});

test('should create dimension and delete qFieldDefs and qFieldLabels from it', () => {
const libraryDimension = { id: 'libraryId', defaults: { customDefault: 'value' } };
const result = handler.createLibraryDimension(libraryDimension);
const result = handler.createLibraryDimension('libraryId', { customDefault: 'value' });

expect(result.qLibraryId).toBe('libraryId');
expect(result.qDef.qSortCriterias).toEqual(sortingProperties);
Expand All @@ -126,12 +123,7 @@ describe('DataPropertyHandler', () => {
});

test('should create a measure with provided expression and label', () => {
const expressionMeasure = {
expression: 'SUM(Sales)',
label: 'Total Sales',
defaults: { customDefault: 'value' },
};
const result = handler.createExpressionMeasure(expressionMeasure);
const result = handler.createExpressionMeasure('SUM(Sales)', 'Total Sales', { customDefault: 'value' });

expect(result.qDef.qDef).toBe('SUM(Sales)');
expect(result.qDef.qLabel).toBe('Total Sales');
Expand All @@ -141,16 +133,14 @@ describe('DataPropertyHandler', () => {
});

test('should initialize qDef and qNumFormat if not provided', () => {
const expressionMeasure = { expression: 'SUM(Sales)', label: 'Total Sales', defaults: {} };
const result = handler.createExpressionMeasure(expressionMeasure);
const result = handler.createExpressionMeasure('SUM(Sales)', 'Total Sales', {});

expect(result.qDef).toBeDefined();
expect(result.qDef.qNumFormat).toBeDefined();
});

test('should handle empty defaults gracefully', () => {
const expressionMeasure = { expression: 'SUM(Sales)', label: 'Total Sales' };
const result = handler.createExpressionMeasure(expressionMeasure);
const result = handler.createExpressionMeasure('SUM(Sales)', 'Total Sales', null);

expect(result.qDef.qDef).toBe('SUM(Sales)');
expect(result.qDef.qLabel).toBe('Total Sales');
Expand All @@ -167,8 +157,7 @@ describe('DataPropertyHandler', () => {
});

test('should create a library measure with provided id and defaults', () => {
const libraryMeasure = { id: 'libraryId', defaults: { customDefault: 'value' } };
const result = handler.createLibraryMeasure(libraryMeasure);
const result = handler.createLibraryMeasure('libraryId', { customDefault: 'value' });

expect(result.qLibraryId).toBe('libraryId');
expect(result.qDef.qNumFormat).toBeDefined();
Expand All @@ -178,16 +167,14 @@ describe('DataPropertyHandler', () => {
});

test('should initialize qDef and qNumFormat if not provided', () => {
const libraryMeasure = { id: 'libraryId', defaults: {} };
const result = handler.createLibraryMeasure(libraryMeasure);
const result = handler.createLibraryMeasure('libraryId', {});

expect(result.qDef).toBeDefined();
expect(result.qDef.qNumFormat).toBeDefined();
});

test('should delete qDef.qDef and qDef.qLabel from the measure', () => {
const libraryMeasure = { id: 'libraryId', defaults: {} };
const result = handler.createLibraryMeasure(libraryMeasure);
const result = handler.createLibraryMeasure('libraryId', {});

expect(result.qDef.qDef).toBeUndefined();
expect(result.qDef.qLabel).toBeUndefined();
Expand Down
Loading