Skip to content

Conversation

@shoudil
Copy link
Contributor

@shoudil shoudil commented Dec 30, 2025

According to the latest legal guideline, correct the license information used for non-login boot binaries.

According to the latest legal guideline, correct the license information
used for non-login boot binaries.

Signed-off-by: Shoudi Li <[email protected]>

SRC_URI = " \
https://${FW_ARTIFACTORY}/${FW_BUILD_ID}/${FW_BIN_PATH}/${BOOTBINARIES}.zip;downloadfilename=${BOOTBINARIES}_r1.0_${PV}.zip;name=bootbinaries \
https://${FW_ARTIFACTORY}/${FW_BUILD_ID}/LICENSE.txt;downloadfilename=LICENSE.${BPN};name=license \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Please don't download licences separately, they should be moved into the tarballs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently all the LICENSE files for these QLI targets are present outside of tarballs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On QCLI1.0, the initial intention should be re-use the same LICENSE for boot binaries tarball and firmware libs tarball.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it should be pushed in. I'm fine to upgrade the LICENSE variable in the recipes, but also please make sure that platform teams get licences sorted out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The firmware-qcom-boot-xxx recipes also take care of CDT tarball, then need to push LICENSE in it as well ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@github-actions
Copy link

Test run workflow

Test jobs for commit 4d296d3

@test-reporting-app
Copy link

Test Results

 12 files  ±0   24 suites  ±0   30m 3s ⏱️ +20s
 45 tests ±0   45 ✅ ±0  0 💤 ±0  0 ❌ ±0 
264 runs  ±0  264 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4d296d3. ± Comparison against base commit 19a7a75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants