-
Notifications
You must be signed in to change notification settings - Fork 170
firmware-boot: correct the license file and hash values #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
According to the latest legal guideline, correct the license information used for non-login boot binaries. Signed-off-by: Shoudi Li <[email protected]>
|
|
||
| SRC_URI = " \ | ||
| https://${FW_ARTIFACTORY}/${FW_BUILD_ID}/${FW_BIN_PATH}/${BOOTBINARIES}.zip;downloadfilename=${BOOTBINARIES}_r1.0_${PV}.zip;name=bootbinaries \ | ||
| https://${FW_ARTIFACTORY}/${FW_BUILD_ID}/LICENSE.txt;downloadfilename=LICENSE.${BPN};name=license \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. Please don't download licences separately, they should be moved into the tarballs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently all the LICENSE files for these QLI targets are present outside of tarballs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On QCLI1.0, the initial intention should be re-use the same LICENSE for boot binaries tarball and firmware libs tarball.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, it should be pushed in. I'm fine to upgrade the LICENSE variable in the recipes, but also please make sure that platform teams get licences sorted out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The firmware-qcom-boot-xxx recipes also take care of CDT tarball, then need to push LICENSE in it as well ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Test run workflowTest jobs for commit 4d296d3
|
According to the latest legal guideline, correct the license information used for non-login boot binaries.