Skip to content

Conversation

@parth-07
Copy link
Contributor

This commit fixes the test
RISCV/standalone/Relaxation/UnalignedCrash/UnalignedCrash.test. The test checks that the link command fails with the insufficient bytes for alignment relaxation error. However, for this test, the link should pass without any errors. It was currently erroring out because of the incorrect fragment address. This commit fixes the test so that the link should fail with the insufficient bytes for alignment relaxation error without relying on the incorrect fragment address.

Resolves #363

This commit fixes the test
RISCV/standalone/Relaxation/UnalignedCrash/UnalignedCrash.test.
The test checks that the link command fails with the insufficient bytes
for alignment relaxation error. However, for this test, the link should
pass without any errors. It was currently erroring out because of the
incorrect fragment address. This commit fixes the test so that the link
should fail with the insufficient bytes for alignment relaxation error
without relying on the incorrect fragment address.

Resolves qualcomm#363

Signed-off-by: Parth Arora <[email protected]>
@parth-07 parth-07 force-pushed the InsufficientAlignmentRelaxation branch from 4e8b508 to 3bf80d3 Compare August 28, 2025 14:39
@parth-07
Copy link
Contributor Author

LLVM mc used to generate incorrect (error-prone?) alignment padding when rvc and norvc code were mixed in the same section. This was fixed here: llvm/llvm-project#150816. The test case present in this PR should not result in 'Insufficient bytes for alignment relaxation' with the LLVM fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link command in Relaxation/UnalignedCrash/UnalignedCrash.test should not fail

1 participant