Fix incorrect handling of negative VMA/LMA #373
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ris-Bali
force-pushed
the
Diag_negative_vma_lma
branch
4 times, most recently
from
75b6234 to
295d211
Compare
parth-07
suggested changes
Sep 1, 2025
| RUN: %not %link %linkopts %t1.1.o -T %p/Inputs/script.t -o %t2_vma.out 2>&1 | %filecheck %s | ||
| RUN: %not %link %linkopts %t1.1.o -T %p/Inputs/script_1.t -o %t2_lma.out 2>&1 | %filecheck %s --check-prefix=LMA | ||
|
|
||
| CHECK: VMA is negative |
Contributor
There was a problem hiding this comment.
Please add the VMA/LMA value in the error message as well.
| "%0: modulo by zero in expression %1") | ||
| DIAG(error_experimental_not_supported, DiagnosticEngine::Error, | ||
| "Linker has only experimental support for handling %0") | ||
| DIAG(error_negative_vma, DiagnosticEngine::Fatal, |
Contributor
There was a problem hiding this comment.
Change the diagnostic severity to error here.
Currently eld does not emit any diagnostic when negative VMA/LMA is specified in the linkerscript. This patch adds an error diagnostic to handle such cases. Signed-off-by: Rishabh Bali <[email protected]>
Ris-Bali
force-pushed
the
Diag_negative_vma_lma
branch
from
295d211 to
3d82029
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently eld does not emit any diagnostic when
negative VMA/LMA is specified in the linkerscript. This patch adds an error diagnostic to handle
such cases.
Fixes: #264