Move PAddr from ELFSection to OutputSectionEntry #635
+23
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parth-07
suggested changes
Nov 27, 2025
| return OE->pAddr(); | ||
| } | ||
|
|
||
| void ELFSection::setPaddr(size_t A) { |
Contributor
There was a problem hiding this comment.
It should be an assert to call setPaddr on input sections that do not have any corresponding OutputSectionEntry. Or perhaps, we should not expose this function through ELFSection and the users that want to set physical address should use:
auto *OSE = S->getOutputSectionEntry();
ASSERT(OSE != nullptr, ...);
OSE->setPaddr(...);Signed-off-by: quic-areg <[email protected]>
quic-seaswara
requested changes
Dec 22, 2025
lib/Readers/ELFSection.cpp
Outdated
|
|
||
| void ELFSection::setPaddr(size_t A) { | ||
| OutputSectionEntry *OE = getOutputSection(); | ||
| ASSERT(OE, "expected putput section"); |
quic-areg
commented
Jan 5, 2026
Signed-off-by: quic-areg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save 8 bytes per section