Make ThinArchiveMissingMember.test LIT check case-insensitive
#672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ris-Bali
force-pushed
the
case_insensitive
branch
from
0353263 to
cf02c07
Compare
partaror
approved these changes
Dec 29, 2025
This patch makes the `ThinArchiveMissingMember.test` case-insensitive this enables the test check to be platform agnostic. Signed-off-by: Rishabh Bali <[email protected]>
Ris-Bali
force-pushed
the
case_insensitive
branch
from
cf02c07 to
0247b50
Compare
| RUN: %ar cr %aropts --thin %t1.lib1.a %t1.1.o | ||
| RUN: %rm %t1.1.o | ||
| RUN: %not %link %linkopts -o %t1.main.out %t1.main.o %t1.lib1.a 2>&1 | %filecheck %s --check-prefix=ERROR | ||
| RUN: %not %link %linkopts -o %t1.main.out %t1.main.o %t1.lib1.a 2>&1 | %filecheck --ignore-case %s --check-prefix=ERROR |
Contributor
Author
There was a problem hiding this comment.
The LLVM diagnostic on Linux and windows has a case difference
On windows : ERROR: Fatal: LLVM: '{{.*}}1.o': No such file or directory
On linux : ERROR: Fatal: LLVM: '{{.*}}1.o': No such File or Directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the
ThinArchiveMissingMember.testcase-insensitive this enables the test check to be platform agnostic.Fixes: #623