Implement structure preserving dynamical decoupling (dd-v2) #7609
Conversation
There was a problem hiding this comment.
LGTM. Thanks, @babacry!
@NoureldinYosri would you be able to take a look when you get a chance? Thanks!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7609 +/- ##
=======================================
Coverage 99.38% 99.38%
=======================================
Files 1091 1091
Lines 97815 97896 +81
=======================================
+ Hits 97214 97295 +81
Misses 601 601 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks Nour for the review! Could you help take a look at the Design and taking another look at the PR? Thanks! @NoureldinYosri |
| INSERTABLE = 3 | ||
|
|
||
| def __str__(self) -> str: | ||
| match self: |
There was a problem hiding this comment.
an enum value has a .value which can be string
class _GateLabel(Enum):
UNKNOWN = '?'
WALL = 'w'
DOOR = 'd'
INSERTABLE = 'i'
def __str__(self) -> str:
return self.value|
|
||
|
|
||
| @frozen | ||
| class _LabeledCircuit: |
There was a problem hiding this comment.
I don't like the _LabeledCircuit/_LabeledGate names ... lets call them _Grid,_CellType since we are turning the circuit into a 2 grid where each cell has one of 4 types.
| return cls(circuit=circuit, gate_types=gate_types, need_to_stop=need_to_stop) | ||
|
|
||
| @staticmethod | ||
| def _backward_set_stopping_slots( |
There was a problem hiding this comment.
since this is a static private method, maybe move it outside the class go/pystyle#decorators
| busy_moment_range_by_qubit = _calc_busy_moment_range_of_each_qubit(orig_circuit) | ||
| labeled_circuit = _LabeledCircuit.from_circuit(orig_circuit, single_qubit_gate_moments_only) | ||
|
|
||
| print(f"Preprocessed input circuit repr:\n{repr}") |
There was a problem hiding this comment.
there are 3 options here
- remove this print line
- hide it behind a
if verbose:and set verbose to default to False - turn it into a logging.info call
3 participants
Previous version of dd allows adding new moments to the circuit in the transformer. In some use cases, we might see a lot of new moments in the transformed circuits. This PR will fix the issues.
First, it captures the circuit's structure. Second, it inserts elements based on the structural information gathered in the initial step: the design.