Skip to content

Conversation

@splch
Copy link
Contributor

@splch splch commented Oct 10, 2025

  • update tests to remove\u* and \x*

relates to #5216

@github-actions github-actions bot added the size: S 10< lines changed <50 label Oct 10, 2025
@splch splch closed this Oct 10, 2025
@splch splch force-pushed the no-ctrl-chars-in-json branch from f66d46b to e8e79bb Compare October 10, 2025 01:29
@github-actions github-actions bot added Size: XS <10 lines changed and removed size: S 10< lines changed <50 labels Oct 10, 2025
@splch splch reopened this Oct 10, 2025
@github-actions github-actions bot added size: S 10< lines changed <50 and removed Size: XS <10 lines changed labels Oct 10, 2025
@splch splch changed the title replace chr(30) and chr(31) delimiters with k and t only use chr(30) and chr(31) delimiters Oct 10, 2025
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.37%. Comparing base (704913b) to head (6198e8d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7699      +/-   ##
==========================================
- Coverage   99.38%   99.37%   -0.01%     
==========================================
  Files        1089     1089              
  Lines       97550    97551       +1     
==========================================
- Hits        96948    96946       -2     
- Misses        602      605       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhucka
Copy link
Contributor

mhucka commented Oct 13, 2025

@splch Thank you for your work on this! When you get a chance, could you update the title of this PR to mention that this is for cirq-ionq, and also add a bit more explanation to the PR description? This will help future contributors and maintainers when reading and searching through past work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants