Skip to content

Conversation

@ElMansourH
Copy link

This MR adds support for configuring additional database object types to be included
in schema management operations, such as materialized views or other database-specific objects.

Changes:

Add documentation for the existing extraPhysicalTableTypes() method
Pass the configuration to Hibernate ORM in FastBootHibernatePersistenceProvider
Add the same implementation for Hibernate Reactive in FastBootHibernateReactivePersistenceProvider
Define a constant for the setting if not already available in Hibernate's AvailableSettings

Example usage: quarkus.hibernate-orm.extra-physical-table-types=MATERIALIZED VIEW,VIEW

@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive labels Sep 10, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 10, 2025

/cc @gsmet (hibernate-orm)

@ElMansourH
Copy link
Author

Hi @geoand, @yrodiere.
I created a new one cause of I found a lot of conflict in the previous one, I hope that one will be enough.
I am gonna close the previous
Thank you,

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. There seems to be a few mistakes, please have a look?

We'll launch CI after you fixed that, because I'm pretty sure some tests would fail in the current state of the PR.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. Let's see what CI thinks of it :)

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@yrodiere
Copy link
Member

Looks like there's a formatting issue :)

See:

File '/home/runner/_work/quarkus/quarkus/extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/HibernateOrmRuntimeConfigPersistenceUnit.java' has not been previously formatted. Please format file (for example by invoking mvn -f extensions/hibernate-orm/runtime net.revelc.code.formatter:formatter-maven-plugin:2.27.0:format) and commit before running validation!

And: https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style

@ElMansourH
Copy link
Author

Looks like there's a formatting issue :)

See:

File '/home/runner/_work/quarkus/quarkus/extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/HibernateOrmRuntimeConfigPersistenceUnit.java' has not been previously formatted. Please format file (for example by invoking mvn -f extensions/hibernate-orm/runtime net.revelc.code.formatter:formatter-maven-plugin:2.27.0:format) and commit before running validation!

And: https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style

done @yrodiere

@ElMansourH ElMansourH force-pushed the feature/Add-support-for-Hibernate-hbm2ddl-extra-physical-table-types branch from 089ae92 to 190adcf Compare September 11, 2025 17:44
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 12, 2025
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Sep 12, 2025

Please squash and force push

@ElMansourH ElMansourH force-pushed the feature/Add-support-for-Hibernate-hbm2ddl-extra-physical-table-types branch from e30e2f1 to a358aeb Compare September 12, 2025 08:12
@ElMansourH
Copy link
Author

Please squash and force push

done

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@ElMansourH ElMansourH force-pushed the feature/Add-support-for-Hibernate-hbm2ddl-extra-physical-table-types branch from 6e56f1b to 85c9a19 Compare September 12, 2025 08:40
@ElMansourH
Copy link
Author

@yrodiere is there anything else to do?

@quarkus-bot

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Sep 14, 2025

😭 Deploy PR Preview failed.

@quarkus-bot

This comment has been minimized.

@ElMansourH ElMansourH force-pushed the feature/Add-support-for-Hibernate-hbm2ddl-extra-physical-table-types branch from 85c9a19 to d42375f Compare September 15, 2025 07:05
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot quarkus-bot bot added area/graphql area/health area/infinispan Infinispan area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jbang Issues related to when using jbang.dev with Quarkus area/kafka area/openapi area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-streams-operators area/scheduler area/smallrye area/testing area/vertx labels Sep 22, 2025
@ElMansourH ElMansourH force-pushed the feature/Add-support-for-Hibernate-hbm2ddl-extra-physical-table-types branch from aa2016e to d6f60c9 Compare September 22, 2025 12:16
@ElMansourH ElMansourH force-pushed the feature/Add-support-for-Hibernate-hbm2ddl-extra-physical-table-types branch from d6f60c9 to c7f02f0 Compare September 22, 2025 12:24
@geoand geoand requested a review from yrodiere September 22, 2025 12:27
@ElMansourH ElMansourH force-pushed the feature/Add-support-for-Hibernate-hbm2ddl-extra-physical-table-types branch from 059d518 to c7f02f0 Compare September 22, 2025 12:33
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 22, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit f8684df.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 22, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f8684df.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

io.quarkus.gradle.devmode.IncludedKotlinBuildDevModeTest.main - History

  • Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:165)

@ElMansourH
Copy link
Author

@yrodiere is everything okey now?

@yrodiere yrodiere merged commit fdecf97 into quarkusio:main Sep 22, 2025
65 of 66 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.29 - main milestone Sep 22, 2025
@yrodiere
Copy link
Member

Merged, thanks!

@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agroal area/amazon-lambda area/arc Issue related to ARC (dependency injection) area/cli Related to quarkus cli (not maven/gradle/etc.) area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/funqy area/gradle Gradle area/graphql area/health area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/infinispan Infinispan area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jbang Issues related to when using jbang.dev with Quarkus area/kafka area/kubernetes area/openapi area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-streams-operators area/scheduler area/smallrye area/testing area/vertx kind/enhancement New feature or request triage/flaky-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a supported configuration property "hibernate.hbm2ddl.extra_physical_table_types"

4 participants