Skip to content

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Oct 7, 2025

Copy link

quarkus-bot bot commented Oct 7, 2025

/cc @Karm (awt), @galderz (awt)

Comment on lines -83 to +84
.includePattern(".*/iio-plugin.*properties$") // Texts for e.g. exceptions strings
.includePattern(".*/.*pf$") // Default colour profiles
.includeGlobs("**/iio-plugin*.properties", // Texts for e.g. exceptions strings
"**/*.pf") // Default colour profiles
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Karm please confirm that the new globs capture what you intended to capture with the patterns. Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Karm this is a kind reminder

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakkak Hey there, I missed the notification. These color profiles and messages properties have tests, so if the glob is wrong, AWT testsuite would fail.

This comment has been minimized.

Copy link

github-actions bot commented Oct 7, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

The new `reachability-metadata.json` file doesn't allow the exclusion of
resources and uses globs for the inclusion of them.

See:
  * oracle/graal#7487
  * oracle/graal#9048
  * oracle/graal#12255
@zakkak zakkak force-pushed the 2025-10-07-deprecate-quarkus.native.resources.exclude branch from 7b02ea8 to abb226e Compare October 7, 2025 21:26
Copy link

quarkus-bot bot commented Oct 7, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit abb226e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Oct 7, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit abb226e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 25

📦 extensions/resteasy-reactive/rest/deployment

io.quarkus.resteasy.reactive.server.test.stream.ErrorDuringStreamingTestCase.noFailure - History

  • expected: <200> but was: <201> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <200> but was: <201>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:166)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:161)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:632)
	at io.quarkus.resteasy.reactive.server.test.stream.ErrorDuringStreamingTestCase.noFailure(ErrorDuringStreamingTestCase.java:54)

📦 extensions/smallrye-graphql/deployment

io.quarkus.smallrye.graphql.deployment.CompletionStageTest.testSourcePost - History

  • 1 expectation failed. Expected status code <200> but was <500>. - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:483)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

io.quarkus.gradle.devmode.IncludedKotlinBuildDevModeTest.main - History

  • Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:165)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will let individual people confirm but this looks good to me (even if having exclusions made kinda sense to me).

@geoand
Copy link
Contributor

geoand commented Oct 13, 2025

Unless anyone has objections with this, I'll merge it tomorrow

@geoand geoand merged commit 91b7dd3 into quarkusio:main Oct 14, 2025
62 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.29 - main milestone Oct 14, 2025
@zakkak zakkak deleted the 2025-10-07-deprecate-quarkus.native.resources.exclude branch October 14, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants