-
Notifications
You must be signed in to change notification settings - Fork 3k
Deprecate quarkus.native.resources.excludes
#50445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate quarkus.native.resources.excludes
#50445
Conversation
.includePattern(".*/iio-plugin.*properties$") // Texts for e.g. exceptions strings | ||
.includePattern(".*/.*pf$") // Default colour profiles | ||
.includeGlobs("**/iio-plugin*.properties", // Texts for e.g. exceptions strings | ||
"**/*.pf") // Default colour profiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Karm please confirm that the new globs capture what you intended to capture with the patterns. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Karm this is a kind reminder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zakkak Hey there, I missed the notification. These color profiles and messages properties have tests, so if the glob is wrong, AWT testsuite would fail.
extensions/jaxb/deployment/src/main/java/io/quarkus/jaxb/deployment/JaxbProcessor.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
The new `reachability-metadata.json` file doesn't allow the exclusion of resources and uses globs for the inclusion of them. See: * oracle/graal#7487 * oracle/graal#9048 * oracle/graal#12255
7b02ea8
to
abb226e
Compare
extensions/kotlin/deployment/src/main/java/io/quarkus/kotlin/deployment/KotlinProcessor.java
Show resolved
Hide resolved
Status for workflow
|
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will let individual people confirm but this looks good to me (even if having exclusions made kinda sense to me).
Unless anyone has objections with this, I'll merge it tomorrow |
The new
reachability-metadata.json
file doesn't allow the exclusion ofresources and uses globs for the inclusion of them.
See:
resource-config.json
oracle/graal#7487Related to #41016