Persistent history / save history to disk #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Off by default. Set Console.History.persistent to true to enable it Does not limit file size, as the code to limit History size doesn't seem to work
Treer
force-pushed
the
feature/persist-history
branch
from
adb93d9 to
00248b2
Compare
Treer
added a commit
to Treer/WorldWanderer
that referenced
this pull request
Apr 4, 2023
bring this code in line with PR submission quentincaffeino/godot-console#110
The QueueCollection stuff is buggy and not necessary, use an array instead. The misc/collection stuff uses a dictionary for a queue, with consecutive integers stored in the dict keys instead of indexing, I assume its some holdover from early versions of Godot. Once items are removed from the start of the queue rather than the end (e.g. if maxLength exceeded) then the length of the dictionary ends up less than the largest key/"index" and a lot of the collection functions break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled by default. Set
Console.History.persistentto true to enable itDoes not limit file size, as the Console's existing code to limit History size doesn't seem to work
Also fixes a crash when you use the down arrow to reverse back through the history
[This is on the Godot4 branch]