Skip to content

Conversation

emrberk
Copy link
Collaborator

@emrberk emrberk commented Aug 6, 2025

  • Introduces a search mechanism that works across multiple tabs, including both active and archived ones. Search results are displayed in a dedicated "Search Panel" on the left.
  • Adds support for "temporary" buffers, which are used when previewing a search result from a closed tab
  • Adds a new shortuct: Ctrl/Cmd + Shift + F will now open the search panel.
  • Repositions the button bar according to the single-file search bar position to prevent overlaps.
Screenshot 2025-08-07 at 16 57 33

@emrberk emrberk requested a review from bluestreak01 August 6, 2025 00:40
@emrberk emrberk requested a review from Copilot August 13, 2025 11:10
Copilot

This comment was marked as outdated.

@emrberk emrberk requested a review from Copilot August 13, 2025 11:58
Copilot

This comment was marked as outdated.

@emrberk emrberk requested a review from Copilot August 17, 2025 17:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive search functionality that enables users to search across multiple tabs, including both active and archived ones. The search results are displayed in a dedicated "Search Panel" on the left side, alongside the existing data sources panel.

  • Adds a cross-tab search mechanism with support for case-sensitive, whole word, and regex search options
  • Introduces temporary buffer functionality for previewing closed tabs without permanently reopening them
  • Integrates a global keyboard shortcut (Ctrl/Cmd + Shift + F) to open the search panel

Reviewed Changes

Copilot reviewed 48 out of 49 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
packages/web-console/src/utils/textSearch.ts Core search engine with web worker support for performance
packages/web-console/src/services/search.ts Search service orchestrating buffer searching and result aggregation
packages/web-console/src/scenes/Search/ Complete search UI components including panel and results display
packages/web-console/src/providers/SearchProvider/ Context provider managing search panel state and keyboard shortcuts
packages/web-console/src/providers/EditorProvider/ Enhanced with temporary buffer support and search integration
packages/web-console/src/scenes/Console/index.tsx Updated layout to support dual left panels (data sources and search)
packages/web-console/src/store/ Database schema updates and buffer management enhancements
Comments suppressed due to low confidence (1)

packages/web-console/src/scenes/Search/SearchPanel.tsx:275

  • The condition keys.length === 0 && keys[0] === 'value' will always be false because if keys.length is 0, then keys[0] will be undefined. This logic appears incorrect.
    }

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

bluestreak01
bluestreak01 previously approved these changes Aug 18, 2025
@emrberk emrberk merged commit aef037b into main Aug 18, 2025
4 checks passed
@emrberk emrberk deleted the feat/search branch August 18, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants