-
Notifications
You must be signed in to change notification settings - Fork 27
feat(web-console): search across multiple tabs #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…itor memory leaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a comprehensive search functionality that enables users to search across multiple tabs, including both active and archived ones. The search results are displayed in a dedicated "Search Panel" on the left side, alongside the existing data sources panel.
- Adds a cross-tab search mechanism with support for case-sensitive, whole word, and regex search options
- Introduces temporary buffer functionality for previewing closed tabs without permanently reopening them
- Integrates a global keyboard shortcut (Ctrl/Cmd + Shift + F) to open the search panel
Reviewed Changes
Copilot reviewed 48 out of 49 changed files in this pull request and generated 8 comments.
Show a summary per file
File | Description |
---|---|
packages/web-console/src/utils/textSearch.ts | Core search engine with web worker support for performance |
packages/web-console/src/services/search.ts | Search service orchestrating buffer searching and result aggregation |
packages/web-console/src/scenes/Search/ | Complete search UI components including panel and results display |
packages/web-console/src/providers/SearchProvider/ | Context provider managing search panel state and keyboard shortcuts |
packages/web-console/src/providers/EditorProvider/ | Enhanced with temporary buffer support and search integration |
packages/web-console/src/scenes/Console/index.tsx | Updated layout to support dual left panels (data sources and search) |
packages/web-console/src/store/ | Database schema updates and buffer management enhancements |
Comments suppressed due to low confidence (1)
packages/web-console/src/scenes/Search/SearchPanel.tsx:275
- The condition
keys.length === 0 && keys[0] === 'value'
will always be false because if keys.length is 0, then keys[0] will be undefined. This logic appears incorrect.
}
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Ctrl/Cmd + Shift + F
will now open the search panel.