Skip to content

[Feature - CSS] Feature/css animations #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AlsoKnownAs-Ax
Copy link
Contributor

Description

Includes 5 common CSS animations.

Type of Change

  • ✨ New snippet
  • πŸ›  Improvement to an existing snippet
  • 🐞 Bug fix
  • πŸ“– Documentation update
  • πŸ”§ Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #148

Copy link

netlify bot commented Jan 3, 2025

βœ… Deploy Preview for quicksnip ready!

Name Link
πŸ”¨ Latest commit 52be1f0
πŸ” Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/677813b3304353000856e4ef
😎 Deploy Preview https://deploy-preview-149--quicksnip.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for your contribution, before we can move on with your snippets, could you please take a look at the comments I left.

Could you also improve the tags on your snippets, per our guidelines in CONTRIBUTING.md tags shouldn't be just the nam of the language, it would be better if you found an another tag instead of just animation that could be unique for each animation

from{
width: 0%
}
f
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@AlsoKnownAs-Ax
Copy link
Contributor Author

AlsoKnownAs-Ax commented Jan 3, 2025

Hello, thank you for the review, I will fix the typo and add some unique tags later on today, about the blinking animation the cursor inherits the text's color, and because the text's default color is white it will be white ( one can add color: red for example ) to make the cursor red. I will add more comments to be more explicit :)

@Mathys-Gasnier
Copy link
Collaborator

Also remove the css tags you have on every snippet.
This is already said in the contributing guidelines in CONTRIBUTING.md, I shouldn't have to ask you to remove them

@Mathys-Gasnier Mathys-Gasnier merged commit b0c00df into quicksnip-dev:main Jan 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - Common CSS animations
3 participants