Replace return with warn! in server loop
#146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return causes the server to stop and all gossiping to end whenever a node leaves on windows. Each node which fails to communicate with the exited node will then stop gossiping.
cattuz
changed the title
return with warn! in server loopreturn with warn! in server loop
|
@rdettai can you have a look? I agree it is weird to exit the loop when receiving a message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return causes the server to stop and all gossiping to end whenever a node leaves on windows. Each node which fails to communicate with the exited node will then stop gossiping.
Attempts to fix #145