Fixing the counter for indexing pipelines #5888
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was stuck to 0 because I forgot to increment the guard upon creation.
fulmicoton-dd
force-pushed
the
paul.masurel/bugfix-indexing-pipeline-counter-not-inc
branch
from
a020ff1 to
1d96c6b
Compare
PSeitz-dd
reviewed
Sep 10, 2025
| let indexing_pipelines_gauge_guard = OwnedGaugeGuard::from_gauge(indexing_pipelines_gauge); | ||
| let mut indexing_pipelines_gauge_guard = | ||
| OwnedGaugeGuard::from_gauge(indexing_pipelines_gauge); | ||
| indexing_pipelines_gauge_guard.add(1); |
There was a problem hiding this comment.
nitpick: I think the guard should do the increment in the constructor
There was a problem hiding this comment.
agreed. i made the change
PSeitz-dd
approved these changes
Sep 10, 2025
|
@fulmicoton for consitency we might want to wrap the index label with |
fulmicoton-dd
force-pushed
the
paul.masurel/bugfix-indexing-pipeline-counter-not-inc
branch
4 times, most recently
from
ceb655f to
a337cdf
Compare
fulmicoton-dd
force-pushed
the
paul.masurel/bugfix-indexing-pipeline-counter-not-inc
branch
from
a337cdf to
570f538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was stuck to 0 because I forgot to increment the guard upon creation.