feat: Add support for cardinality aggregation #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for cardinality aggregation by: - Updating the `tantivy` dependency to version 0.25.0. - Adding a `cardinality` method to the `Searcher` class to make it easier to use this feature.
cjrh
requested changes
Aug 25, 2025
There was a problem hiding this comment.
This is great 💯
Please add:
- Python tests that use this new feature
- Some documentation in the docs that show an example
- Fix the CI lint error
I would normally prefer the tantivy bump to 0.25 to be in its own PR, as sometimes there are extra things to update, but in this case it looks clean so we can do it together.
This commit adds support for cardinality aggregation by: - Updating the `tantivy` dependency to version 0.25.0. - Adding a `cardinality` method to the `Searcher` class to make it easier to use this feature. - Adding a Python test for the new feature. - Adding documentation with an example for the new feature. - Fixing a CI lint error.
This commit adds support for cardinality aggregation by: - Updating the `tantivy` dependency to version 0.25.0. - Adding a `cardinality` method to the `Searcher` class to make it easier to use this feature. - Adding a Python test for the new feature. - Adding documentation with an example for the new feature. - Fixing a CI lint error.
cjrh
reviewed
Sep 8, 2025
cjrh
approved these changes
Sep 8, 2025
Co-authored-by: Caleb Hattingh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for cardinality aggregation by:
tantivydependency to version 0.25.0.cardinalitymethod to theSearcherclass to make it easier to use this feature.