Skip to content

Conversation

noracato
Copy link
Member

@noracato noracato commented Jul 3, 2025

After hours filters.

Area code filters for saved scenarios

@noracato noracato requested a review from louispt1 July 3, 2025 19:12
@louispt1
Copy link
Collaborator

louispt1 commented Jul 4, 2025

It looks good!

There is just this bug - any idea why there are multiple 'Netherlands' instances?

image

@noracato
Copy link
Member Author

noracato commented Jul 8, 2025

That's the 2015 and 2019 datasets. They have the same translation in the locales, but a different underlying area code. We could opt to change the translation of the older one into something like "Netherlands - 2015".

@louispt1
Copy link
Collaborator

That's the 2015 and 2019 datasets. They have the same translation in the locales, but a different underlying area code. We could opt to change the translation of the older one into something like "Netherlands - 2015".

Good idea! I think with that change this is good to go

@noracato
Copy link
Member Author

Preference of the modellers is to put all Netherlands together and add an extra filter for start year. I can imagine the consulting team not agreeing to this, and preferring the (old) suffix. They don't like the start year to be shown.

I'll discuss with @MartLubben when he's back from holidays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants