Skip to content

Let the pulse coeff handle complex coefficients #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Let the pulse coeff handle complex coefficients #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9cd0b98
lets _fill_coeff handle complex coefficients
Wikstahl Jun 15, 2022
e879a53
Merge branch 'master' of github.com:Wikstahl/qutip-qip
Wikstahl Jun 15, 2022
4c72680
Install qutip-qtrl in the test action for qutip5
BoxiLi Mar 14, 2023
0e10089
Let the pulse coeff use the existing dtype
BoxiLi Mar 14, 2023
380b559
Merge branch 'master' into pr/149
BoxiLi Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,12 @@ jobs:
python -m pip install numpy scipy cython
python -m pip install 'git+https://github.com/qutip/qutip.git${{ matrix.qutip-version }}'

# For qutip-v5 qutip.control is replaced by qutip-qtrl
- name: Install qutip-qtrl from PyPI
if: ${{ matrix.qutip-version == '@master'}}
run: |
python -m pip install qutip-qtrl

- name: Install Qiskit from PyPI
if: ${{ matrix.qiskit-version != '' }}
run: python -m pip install 'qiskit${{ matrix.qiskit-version }}'
Expand Down
2 changes: 1 addition & 1 deletion src/qutip_qip/pulse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ def _fill_coeff(old_coeffs, old_tlist, full_tlist, args=None, tol=1.0e-10):
old_coeffs = np.concatenate([old_coeffs, [0]])
new_n = len(full_tlist)
old_ind = 0 # index for old coeffs and tlist
new_coeff = np.zeros(new_n)
new_coeff = np.zeros(new_n, dtype=old_coeffs.dtype)
for new_ind in range(new_n):
t = full_tlist[new_ind]
if old_tlist[0] - t > tol:
Expand Down