Skip to content

Conversation

edbzn
Copy link
Contributor

@edbzn edbzn commented May 13, 2025

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

In our CI, we face a sporadic timeout issue when running a test target that involves qwikNxVite. This change fixes the problem by using the right way to get the project graph and project configs, dropping the deprecated readWorkspaceConfig API in favor of the devkit.

Note that Nx 21 removed the function, so it's a needed refactoring anyway.

Use cases and why

No sporadic timeout issue when running a test target including qwikNxVite.

Screenshots/Demo

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

pkg-pr-new bot commented May 13, 2025

Open in StackBlitz

npm i https://pkg.pr.new/qwikifiers/qwik-nx@248

commit: 0c05a66

@dmitry-stepanenko
Copy link
Contributor

@edbzn thank you!

Just FYI, in the recent versions qwik itself now has a capability of resolving library paths, so qwikNxVite plugin is no longer needed. I'm going to add a migration for the v4 (upcoming release for nx@21) to fully remove the plugin from the users codebase.

Meanwhile let's merge this as it might be helpful for those who still use older versions of Qwik

@dmitry-stepanenko dmitry-stepanenko merged commit ff6d445 into qwikifiers:main May 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants