Skip to content

Drop escape valve for possible unknown error issue #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IndrajeetPatil merged 2 commits into from
Dec 17, 2025
Merged

Drop escape valve for possible unknown error issue #2989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10357f0
drop escape valve
MichaelChirico Dec 8, 2025
26a5a72
Merge branch 'main' into drop-escape-valve
IndrajeetPatil Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions R/shared_constants.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,9 +280,7 @@ extract_glued_symbols <- function(expr, interpret_glue = TRUE) {

glued_symbols <- new.env(parent = emptyenv())
for (glue_call in glue_calls) {
# TODO(#2475): Drop tryCatch().
parsed_call <-
tryCatch(xml2lang(glue_call), error = unexpected_glue_parse_error, warning = unexpected_glue_parse_error)
parsed_call <- xml2lang(glue_call)
parsed_call[[".envir"]] <- glued_symbols
parsed_call[[".transformer"]] <- glue_symbol_extractor
# #1459: syntax errors in glue'd code are ignored with warning, rather than crashing lint
Expand All @@ -291,14 +289,6 @@ extract_glued_symbols <- function(expr, interpret_glue = TRUE) {
names(glued_symbols)
}

unexpected_glue_parse_error <- function(cond) {
# nocov start
cli_abort(c(
x = "Unexpected failure to parse glue call.",
i = "Please report: {conditionMessage(cond)}"
))
# nocov end
}
glue_parse_failure_warning <- function(cond) {
cli_warn(c(
x = "Evaluating glue expression while testing for local variable usage failed: {conditionMessage(cond)}",
Expand Down
Loading