-
Notifications
You must be signed in to change notification settings - Fork 61
ICMP Redirects vulnerability remediation #1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkeirns
wants to merge
6
commits into
main
Choose a base branch
from
dk-vuln-remediation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−0
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
be477fc
ICMP Redirects vulnerability remediation
dkeirns 110abee
fixed missing space character
dkeirns 738a7e3
fix yes/true setting
dkeirns ffb4c25
additional spacing fixes
dkeirns 10df5e7
fixed trailing spaces
dkeirns 2214949
removing an extra blank line at eof
dkeirns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| --- | ||
| # Copyright 2024, Rackspace Technology, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| - name: Set net.ipv4.conf.all.accept_redirects to 0 | ||
| ansible.posix.sysctl: | ||
| name: net.ipv4.conf.all.accept_redirects | ||
| value: 0 | ||
| sysctl_set: true | ||
| become: true | ||
|
|
||
| - name: Set net.ipv4.conf.default.accept_redirects to 0 | ||
| ansible.posix.sysctl: | ||
| name: net.ipv4.conf.default.accept_redirects | ||
| value: 0 | ||
| sysctl_set: true | ||
| become: true | ||
|
|
||
| - name: Set net.ipv4.conf.all.secure_redirects to 0 | ||
| ansible.posix.sysctl: | ||
| name: net.ipv4.conf.all.secure_redirects | ||
| value: 0 | ||
| sysctl_set: true | ||
| become: true | ||
|
|
||
| - name: Set net.ipv4.conf.default.secure_redirects to 0 | ||
| ansible.posix.sysctl: | ||
| name: net.ipv4.conf.default.secure_redirects | ||
| value: 0 | ||
| sysctl_set: true | ||
| become: true | ||
|
|
||
| - name: Update /etc/sysctl.conf | ||
| ansible.builtin.lineinfile: | ||
| path: /etc/sysctl.conf | ||
| regexp: "{{ item.regexp }}" | ||
| line: "{{ item.line }}" | ||
| state: present | ||
| with_items: | ||
| - {regexp: '^net.ipv4.conf.all.accept_redirects', line: 'net.ipv4.conf.all.accept_redirects = 0'} | ||
| - {regexp: '^net.ipv4.conf.default.accept_redirects', line: 'net.ipv4.conf.default.accept_redirects = 0'} | ||
| - {regexp: '^net.ipv4.conf.all.secure_redirects', line: 'net.ipv4.conf.all.secure_redirects = 0'} | ||
| - {regexp: '^net.ipv4.conf.default.secure_redirects', line: 'net.ipv4.conf.default.secure_redirects = 0'} | ||
|
|
||
| - name: Apply changes to /etc/sysctl.conf | ||
| ansible.builtin.command: sysctl -p /etc/sysctl.conf | ||
| become: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, with the previous use of the
ansible.posix.sysctlwithsysctl_setthese options should already be persistent on the system meaning this task would not be needed. Thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loop with the separated regexp: and line are easier to read. I'd be happy to test it and update. As for sysctl_set, my understanding from the documentation is that it is the equivalent of sysctl -w which does not appear to write the configuration line to /etc/sysctl.conf. Therefore to ensure the lines were written to the config file, I have been updating the file as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the module will set the valures in the default sysctl file, unless specifically disabled. https://docs.ansible.com/projects/ansible/latest/collections/ansible/posix/sysctl_module.html#parameter-sysctl_file