-
Notifications
You must be signed in to change notification settings - Fork 61
Feat: Update ovn-setup #1358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feat: Update ovn-setup #1358
+505
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore the Galera deployment option to MariaDB documentation. The Galera kustomization configuration was already present in the repository but the documentation was previously removed. This adds back the Galera deployment option alongside the existing Replication and AIO configurations.
Add ConfigMap-based state tracking to prevent network loops during reconfiguration and enable OVS bond creation with advanced options. Changes: - Add per-node ConfigMap state tracking (ovn-state-<nodename>) - Implement first-run detection with graceful handling - Smart cleanup of old ports/bonds when configuration changes - Prevent network loops by removing old ports before adding new ones - Add support for ovn.openstack.org/bonds annotation - Add support for ovn.openstack.org/bond-options annotation - Support LACP configuration with MII monitoring and timing options - Validate port types before removal to protect system ports - Update RBAC to allow ConfigMap operations - Add comprehensive documentation with examples
Adds comprehensive state tracking and bond configuration support to the OVN setup script, with intelligent cleanup to prevent network loops and conflicts when changing configurations. Features: - State tracking via per-node ConfigMaps to track previous configurations - LACP bond support with configurable options (MII monitoring, lacp-time, etc.) - Intelligent port cleanup when changing from single ports to bonds - Orphaned port detection and removal - Prevention of conflicts when bonds are listed in port mappings - File-based state transfer between containers (kubectl availability fix) The script now safely handles configuration changes such as: - Changing from single interface (ens6f0) to bonded interfaces (bond0) - Removing old ports before creating bonds with those interfaces - Skipping bond creation as regular ports to prevent conflicts This enables operators to reconfigure nodes without manual cleanup or risk of network loops from simultaneous port attachments.
cloudnull
reviewed
Dec 10, 2025
cloudnull
reviewed
Dec 10, 2025
cloudnull
reviewed
Dec 10, 2025
Co-authored-by: Kevin Carter <[email protected]>
Improved bond interface handling to avoid unnecessary recreation by comparing existing bond configuration (bridge, members, mode, LACP) with desired state. Only recreates bonds when actual configuration changes are detected, reducing network disruptions during OVN setup runs.
cloudnull
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ove-setup to cleanup interfaces when they are changed and added feature to create bonds on the bridge