-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Enroll without nautobot #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stevekeay
wants to merge
11
commits into
main
Choose a base branch
from
enroll-without-nautobot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
957605f to
cdd2267
Compare
7160e7d to
e803c56
Compare
ca06fbd to
f9ddbee
Compare
e897e5a to
6b74a6e
Compare
6b74a6e to
0589215
Compare
RSabounds
reviewed
Dec 3, 2025
0589215 to
79aff67
Compare
We have data freshly discovered from the BMC. We were updating Nautobot, then fetching the same data back from Nautobot to populate Ironic. This code is re-written to use BMC data directly, allowing us to enrol independently from Nautobot. We now expect Nautotbot to be updated in response to events emitted by OpenStack, so there is no need for us to write directly to the Nautobot API.
Interfaces are to be managed by a post-inspection hook
79aff67 to
ca260e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nautobot is (or is intended to be) updated by events from OpenStack so we don't need to create anything in Nautobot on enrol.
We remove a lot of other functionality from the enrol script, with the intention that #1347 and other changes will take on some of the responsibility in post-inspection hooks.
Specifically we no longer do anything with interfaces or flavors.