Skip to content

Automated Resyntax fixes #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Automated Resyntax fixes #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8ea329d
Fix 2 occurrences of `in-hash-to-in-hash-values`
resyntax-ci[bot] Oct 12, 2025
9532547
Fix 1 occurrence of `hash-set!-ref-to-hash-update!`
resyntax-ci[bot] Oct 12, 2025
df9075a
Fix 9 occurrences of `let-to-define`
resyntax-ci[bot] Oct 12, 2025
66ca3c3
Fix 3 occurrences of `nested-for-to-for*`
resyntax-ci[bot] Oct 12, 2025
ba4e734
Fix 2 occurrences of `in-hash-to-in-hash-keys`
resyntax-ci[bot] Oct 12, 2025
73d3f26
Fix 1 occurrence of `if-else-false-to-and`
resyntax-ci[bot] Oct 12, 2025
958bb0f
Fix 1 occurrence of `when-expression-in-for-loop-to-when-keyword`
resyntax-ci[bot] Oct 12, 2025
7413859
Fix 1 occurrence of `and-let-to-cond`
resyntax-ci[bot] Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 24 additions & 16 deletions drracket-tool-text-lib/drracket/private/syncheck/contract-traversal.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,22 +29,30 @@
[_ (void)]))

;; fill in the coloring-plans table for boundary contracts
(for ([(start-k start-val) (in-hash boundary-start-map)])
(for ([start-val (in-hash-values boundary-start-map)])
(for ([start-stx (in-list start-val)])
(do-contract-traversal start-stx #t
coloring-plans already-jumped-ids
low-binders binding-inits
domain-map range-map
(do-contract-traversal start-stx
#t
coloring-plans
already-jumped-ids
low-binders
binding-inits
domain-map
range-map
#t
binder+mods-binder)))

;; fill in the coloring-plans table for internal contracts
(for ([(start-k start-val) (in-hash internal-start-map)])
(for ([start-val (in-hash-values internal-start-map)])
(for ([start-stx (in-list start-val)])
(do-contract-traversal start-stx #f
coloring-plans already-jumped-ids
low-binders binding-inits
domain-map range-map
(do-contract-traversal start-stx
#f
coloring-plans
already-jumped-ids
low-binders
binding-inits
domain-map
range-map
#f
binder+mods-binder)))

Expand Down Expand Up @@ -210,7 +218,7 @@
(let loop ([val (syntax-property stx prop)])
(cond
[(symbol? val)
(hash-set! map val (cons stx (hash-ref map val '())))]
(hash-update! map val (λ (v) (cons stx v)) '())]
[(pair? val)
(loop (car val))
(loop (cdr val))])))
Expand All @@ -221,11 +229,11 @@
;; approximate this by just asking 'did this identifier come from the core?' (which is known
;; to not bind any contracts (I hope))
(define (known-predicate? id)
(let ([ib (identifier-binding id)])
(and (list? ib)
(let ([src (list-ref ib 0)])
(let-values ([(base rel) (module-path-index-split src)])
(member base '('#%kernel '#%runtime racket racket/base scheme scheme/base)))))))
(define ib (identifier-binding id))
(and (list? ib)
(let ([src (list-ref ib 0)])
(let-values ([(base rel) (module-path-index-split src)])
(member base '('#%kernel '#%runtime racket racket/base scheme scheme/base))))))

(define (give-up stx boundary-contract? coloring-plans)
(let loop ([stx stx])
Expand Down
Loading