-
-
Notifications
You must be signed in to change notification settings - Fork 99
fix CSS for manual style for H1 tag for title #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Argh! The first two commits have already been merged, I guess I should have created a new branch. I suppose whoever merges this should just cherry-pick 8a742c9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 0 files in this pull request and found no issues.
Please rebase this branch on top of master and then force push the branch. |
8a742c9
to
19fd59e
Compare
Thanks sam. In reviewing the diffs again, I noticed a missing comma in the CSS. I don't think I can squash that commit at this point without screwing up the sync between my local git and my github git, so I just pushed it. Maybe you can squash it when you pull this. Sorry I didn't notice the huge difference between the scribble/base and scribble/manual CSS before this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 0 files in this pull request and found no issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 0 files in this pull request and found no issues.
See scribble issue #527 |
Oops! Fix the CSS files for the manual style for the change to h1 for titles. The CSS for the base style was fixed in the original pull request.
9abbe01
to
813f759
Compare
@samth, I finally managed to squash everything into one commit. I hope you can get it into v8.18, as the Racket docs look funny without it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 0 files in this pull request and found no issues.
Oops! Fix the CSS for the manual style for the change to h1 for titles.
The base style was fixed in the original pull request.