Skip to content

Conversation

stevebyan
Copy link
Contributor

Oops! Fix the CSS for the manual style for the change to h1 for titles.

The base style was fixed in the original pull request.

@stevebyan stevebyan changed the title H1 tag for title fix CSS for manual style for H1 tag for title Jul 13, 2025
@stevebyan
Copy link
Contributor Author

Argh! The first two commits have already been merged, I guess I should have created a new branch. I suppose whoever merges this should just cherry-pick 8a742c9

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resyntax analyzed 0 files in this pull request and found no issues.

@samth
Copy link
Member

samth commented Jul 15, 2025

Please rebase this branch on top of master and then force push the branch.

@stevebyan
Copy link
Contributor Author

stevebyan commented Jul 15, 2025

Thanks sam. In reviewing the diffs again, I noticed a missing comma in the CSS. I don't think I can squash that commit at this point without screwing up the sync between my local git and my github git, so I just pushed it. Maybe you can squash it when you pull this.

Sorry I didn't notice the huge difference between the scribble/base and scribble/manual CSS before this.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resyntax analyzed 0 files in this pull request and found no issues.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resyntax analyzed 0 files in this pull request and found no issues.

@stevebyan
Copy link
Contributor Author

See scribble issue #527

Oops! Fix the CSS files for the manual style for the change to h1 for titles. The CSS for the base style was fixed in the original pull request.
@stevebyan
Copy link
Contributor Author

stevebyan commented Aug 4, 2025

@samth, I finally managed to squash everything into one commit. I hope you can get it into v8.18, as the Racket docs look funny without it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resyntax analyzed 0 files in this pull request and found no issues.

@mflatt mflatt merged commit b610ab7 into racket:master Aug 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants