Skip to content

chore: add Node/React matrix CI #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add Node/React matrix CI #1538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: CI

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]

permissions:
contents: read
pull-requests: read

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version: ['18', '20']
react-version: ['18', '19']
Comment on lines +22 to +24
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Remove nonexistent React 19 from test matrix

The workflow introduces a matrix entry react-version: ['18', '19'] and later installs react@${{ matrix.react-version }}. NPM does not ship a stable react@19 package yet, so npm install react@19 react-dom@19 --no-save fails with a 403/404 whenever the matrix picks the 19 value, turning every CI run red. Use an existing prerelease tag (e.g. @next or 19.0.0-rc) or drop the 19 slot until a publishable version exists.

Useful? React with 👍 / 👎.

steps:
- uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Install dependencies
run: npm ci

- name: Use React ${{ matrix.react-version }}
run: |
npm install react@${{ matrix.react-version }} react-dom@${{ matrix.react-version }} --no-save
npm dedupe

- name: Run tests
run: npm test
Loading