Fix R_ARM_CALL relocs #22877
Closed
Fix R_ARM_CALL relocs #22877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trufae
force-pushed
the
arm-call-reloc
branch
3 times, most recently
from
6843a81 to
8b6217e
Compare
trufae
force-pushed
the
arm-call-reloc
branch
2 times, most recently
from
a75d14a to
144b79d
Compare
trufae
force-pushed
the
arm-call-reloc
branch
from
144b79d to
ecbe926
Compare
trufae
force-pushed
the
arm-call-reloc
branch
from
ecbe926 to
c657ae3
Compare
Remove debug prints and hardcoded values from R_ARM_CALL relocation handling. This fixes the issue where instructions with relocated addresses were replaced with stmdaeq.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the R_ARM_CALL relocation handling in ELF binaries for ARM architecture.
Previously, when applying relocations with
bin.relocs.apply=trueorbin.cache=true, instructions with relocated addresses were incorrectly disassembled as 'stmdaeq' instead of the correct 'bl' instruction.The fix removes debug prints and hardcoded values from the relocation code, ensuring proper calculation of the addend for R_ARM_CALL relocations.
Tested with media_clock.ko kernel module, which now correctly shows 'bl' instructions after relocation application.
Closes #22822