Skip to content

fix: click callback inside SelectItem shouldn't be omitted #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: click callback inside SelectItem shouldn't be omitted #3472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions apps/storybook/stories/select.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,47 @@ export const WithinDialog = () => (
</div>
);

export const WithLink = () => (
<div style={{ padding: 50 }}>
<Label>
Choose a number:
<Select.Root defaultValue="two">
<Select.Trigger className={styles.trigger}>
<Select.Value />
<Select.Icon />
</Select.Trigger>
<Select.Portal>
<Select.Content className={styles.content}>
<Select.Viewport className={styles.viewport}>
<Select.Item className={styles.item} value="one">
<Select.ItemText>One</Select.ItemText>
<a href="/#" target="_blank" rel="noopener noreferrer">
(link)
</a>
<Select.ItemIndicator className={styles.indicator}>
<TickIcon />
</Select.ItemIndicator>
</Select.Item>
<Select.Item className={styles.item} value="two">
<Select.ItemText>Two</Select.ItemText>
<Select.ItemIndicator className={styles.indicator}>
<TickIcon />
</Select.ItemIndicator>
</Select.Item>
<Select.Item className={styles.item} value="three">
<Select.ItemText>Three</Select.ItemText>
<Select.ItemIndicator className={styles.indicator}>
<TickIcon />
</Select.ItemIndicator>
</Select.Item>
</Select.Viewport>
</Select.Content>
</Select.Portal>
</Select.Root>
</Label>
</div>
);

export const WithVeryLongSelectItems = () => (
<div style={{ paddingLeft: 300 }}>
<Label>
Expand Down
9 changes: 7 additions & 2 deletions packages/react/select/src/select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,8 +1269,13 @@ const SelectItem = React.forwardRef<SelectItemElement, SelectItemProps>(

const handleSelect = () => {
if (!disabled) {
context.onValueChange(value);
context.onOpenChange(false);
const startTransition = React.startTransition
? React.startTransition
: window.requestAnimationFrame;
startTransition(() => {
context.onValueChange(value);
context.onOpenChange(false);
});
}
};

Expand Down