Skip to content

Implement multi select #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+501 −29
Open

Implement multi select #3522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
038732c
Implement multi select
Zach-Jaensch May 1, 2025
f5dc775
add tests
Zach-Jaensch May 1, 2025
625e645
Create quiet-schools-leave.md
Zach-Jaensch May 1, 2025
b3ee588
fix invalid role
Zach-Jaensch May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/quiet-schools-leave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@repo/storybook": patch
"@radix-ui/react-select": minor
---

Support `multiple` prop and array `value` and `defaultValue` on Select (#3522)
196 changes: 195 additions & 1 deletion apps/storybook/stories/select.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,53 @@ export const Styled = () => (
</div>
);

export const MultiSelectStyled = () => (
<div style={{ display: 'flex', gap: 20, padding: 50 }}>
{POSITIONS.map((position) => (
<Label key={position}>
Choose some numbers:
<Select.Root defaultValue={['two']} multiple>
<Select.Trigger className={styles.trigger}>
<Select.Value />
<Select.Icon />
</Select.Trigger>
<Select.Portal>
<Select.Content className={styles.content} position={position} sideOffset={5}>
<Select.Viewport className={styles.viewport}>
<Select.Item className={styles.item} value="one">
<Select.ItemText>
One<span aria-hidden> 👍</span>
</Select.ItemText>
<Select.ItemIndicator className={styles.indicator}>
<TickIcon />
</Select.ItemIndicator>
</Select.Item>
<Select.Item className={styles.item} value="two">
<Select.ItemText>
Two<span aria-hidden> 👌</span>
</Select.ItemText>
<Select.ItemIndicator className={styles.indicator}>
<TickIcon />
</Select.ItemIndicator>
</Select.Item>
<Select.Item className={styles.item} value="three">
<Select.ItemText>
Three<span aria-hidden> 🤘</span>
</Select.ItemText>
<Select.ItemIndicator className={styles.indicator}>
<TickIcon />
</Select.ItemIndicator>
</Select.Item>
</Select.Viewport>
<Select.Arrow />
</Select.Content>
</Select.Portal>
</Select.Root>
</Label>
))}
</div>
);

export const Controlled = () => {
const [value, setValue] = React.useState('uk');
return (
Expand Down Expand Up @@ -121,6 +168,72 @@ export const Controlled = () => {
);
};

export const MultiSelectControlled = () => {
const labelMap = {
fr: ['🇫🇷', 'France'],
uk: ['🇬🇧', 'United Kingdom'],
es: ['🇪🇸', 'Spain'],
} as const;
const [value, setValue] = React.useState(['uk']);

const [flags, countries] = Object.entries(labelMap).reduce(
(mem, [key, [flag, country]]) => {
if (value.includes(key)) {
mem[0] += ' ' + flag;
mem[1] += ' ' + country;
}
return mem;
},
['', '']
);
return (
<div style={{ display: 'flex', gap: 20, padding: 50 }}>
{POSITIONS.map((position) => (
<Label key={position}>
Choose a country:
<Select.Root value={value} onValueChange={setValue} multiple>
<Select.Trigger className={styles.trigger}>
<Select.Value aria-label={countries}>{flags}</Select.Value>
<Select.Icon />
</Select.Trigger>
<Select.Portal>
<Select.Content className={styles.content} position={position} sideOffset={5}>
<Select.Viewport className={styles.viewport}>
<Select.Item className={styles.item} value="fr">
<Select.ItemText>
France<span aria-hidden> 🇫🇷</span>
</Select.ItemText>
<Select.ItemIndicator className={styles.indicator}>
<TickIcon />
</Select.ItemIndicator>
</Select.Item>
<Select.Item className={styles.item} value="uk">
<Select.ItemText>
United Kingdom<span aria-hidden> 🇬🇧</span>
</Select.ItemText>
<Select.ItemIndicator className={styles.indicator}>
<TickIcon />
</Select.ItemIndicator>
</Select.Item>
<Select.Item className={styles.item} value="es">
<Select.ItemText>
Spain<span aria-hidden> 🇪🇸</span>
</Select.ItemText>
<Select.ItemIndicator className={styles.indicator}>
<TickIcon />
</Select.ItemIndicator>
</Select.Item>
</Select.Viewport>
<Select.Arrow />
</Select.Content>
</Select.Portal>
</Select.Root>
</Label>
))}
</div>
);
};

export const Position = () => (
<div
style={{
Expand Down Expand Up @@ -452,7 +565,16 @@ export const WithinForm = () => {

function handleChange(event: React.FormEvent<HTMLFormElement>) {
const formData = new FormData(event.currentTarget);
setData(Object.fromEntries((formData as any).entries()));
const formDataEntries = Array.from(formData.entries()).reduce(
(acc, [key, value]) => {
const existing = Array.isArray(acc[key]) ? acc[key] : acc[key] ? [acc[key]] : [];
acc[key] = [value, ...existing];
return acc;
},
{} as Record<string, string | File | (string | File)[]>
);

setData(formDataEntries);
}

return (
Expand Down Expand Up @@ -510,6 +632,78 @@ export const WithinForm = () => {
);
};

export const MultiSelectWithinForm = () => {
const [data, setData] = React.useState({});

function handleChange(event: React.FormEvent<HTMLFormElement>) {
const formData = new FormData(event.currentTarget);
const formDataEntries = Array.from(formData.entries()).reduce(
(acc, [key, value]) => {
const existing = Array.isArray(acc[key]) ? acc[key] : acc[key] ? [acc[key]] : [];
acc[key] = [value, ...existing];
return acc;
},
{} as Record<string, string | File | (string | File)[]>
);

setData(formDataEntries);
}

return (
<form
style={{ padding: 50 }}
onSubmit={(event) => {
handleChange(event);
event.preventDefault();
}}
onChange={handleChange}
>
<Label style={{ display: 'block' }}>
Name
<input name="name" autoComplete="name" style={{ display: 'block' }} />
</Label>
<br />
<Label style={{ display: 'block' }}>
Country
<Select.Root name="country" autoComplete="country" defaultValue={['fr', 'uk']} multiple>
<Select.Trigger className={styles.trigger}>
<Select.Value />
<Select.Icon />
</Select.Trigger>
<Select.Portal>
<Select.Content className={styles.content}>
<Select.Viewport className={styles.viewport}>
<Select.Item className={styles.item} value="fr">
<Select.ItemText>France</Select.ItemText>
<Select.ItemIndicator className={styles.indicator}>
<TickIcon />
</Select.ItemIndicator>
</Select.Item>
<Select.Item className={styles.item} value="uk">
<Select.ItemText>United Kingdom</Select.ItemText>
<Select.ItemIndicator className={styles.indicator}>
<TickIcon />
</Select.ItemIndicator>
</Select.Item>
<Select.Item className={styles.item} value="es">
<Select.ItemText>Spain</Select.ItemText>
<Select.ItemIndicator className={styles.indicator}>
<TickIcon />
</Select.ItemIndicator>
</Select.Item>
</Select.Viewport>
</Select.Content>
</Select.Portal>
</Select.Root>
</Label>
<br />
<button type="submit">Submit</button>
<br />
<pre>{JSON.stringify(data, null, 2)}</pre>
</form>
);
};

export const DisabledWithinForm = () => {
const [data, setData] = React.useState({});

Expand Down
1 change: 1 addition & 0 deletions packages/react/select/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
"@repo/typescript-config": "workspace:*",
"@types/react": "^19.0.7",
"@types/react-dom": "^19.0.3",
"@radix-ui/react-label": "workspace:*",
"eslint": "^9.18.0",
"react": "^19.1.0",
"react-dom": "^19.1.0",
Expand Down
Loading