Fix tooltip skipDelayDuration with disableHoverableContent

[jamiebuilds]

Background

Scenario:

• Multiple <Tooltip.Trigger>'s are 0px apart
• <Tooltip.Provider skipDelayDuration={0}>
• <Tooltip.Root disableHoverableContent> (not sure why this is required to reproduce)

Problem:

• The delayDuration will be skipped, even though skipDelayDuration is 0

Solution

Before:

• Even when skipDelayDuration was set to 0:
  • onOpen sets skipDelayTimerRef.current = false
  • onClose waits to set skipDelayTimerRef.current = true for 0ms in setTimeout()
• So there's a very brief tick where skipDelayTimerRef.current is false

onOpen={() => {
  clearTimeout(skipDelayTimerRef.current)
  isOpenDelayedRef.current = false
}}
onClose={() => {
  setTimeout(() => {
    isOpenDelayedRef.current = true
  }, skipDelayDuration /* 0ms */)
}}

After:

• When skipDelayDuration is <= 0:
  • onOpen never set skipDelayTimerRef.current = false
  • onClose instantly set skipDelayTimerRef.current = true
    • Just in case skipDelayDuration changed between onOpen and onClose

onOpen={() => {
  if (skipDelayDuration > 0) {
    isOpenDelayedRef.current = false
  }
}}
onClose={() => {
  if (skipDelayDuration > 0) {
    // ...setTimeout...
  } else {
    isOpenDelayedRef.current = false
  }
}}

Additional Fix

The cleanup code for skipDelayTimerRef is always using the initial value even as many different timers may be set/cleared.

const skipDelayTimerRef = useRef(0)

useEffect(() => {
  const skipDelayTimer = skipDelayTimerRef.current
  return () => {
    // `skipDelayTimer` will always be `0`
    // unless `onClose` was somehow called before this effect fired
    // but even then, it will be the initial timer forever
    clearTimeout(skipDelayTimer)
  }
}, [])

After: Always clear the last value of skipDelayTimerRef

useEffect(() => {
  return () => clearTimeout(skipDelayTimerRef.current);
}, [])

[changeset-bot]

⚠️ No Changeset found

Latest commit: a1ef3b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR