-
Notifications
You must be signed in to change notification settings - Fork 7
Brendan/animation 2 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
manolingam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deploy is successful and is looking good but there's a few more things that needs to be fixed.
-
The banner image in manifesto is not centered when going below large screen resolutions. It should be centered.
-
Also, the main hero banner doesn't appear for mobile screens & is also off the layout when on tab kind of resolutions.
-
There are a few empty files in the pr which needs to be removed. For example,
animation/base/displace.jsis empty. -
And in the
public/animation/imgfolder, I think there are images that are not used for the animation. Pls remove images that are not used for the animation. For example, our logo isn't animated right? But there are imgs related to it & a few others. -
Finally, can you remove the
.vscodefolder in the pr & add it to.gitignore.
Thank you :))
…to brendan/animation-2
|
@manolingam Thanks for your review. I've addressed everything and its all reflected here in the PR. |
No description provided.