Windows Clusters Page Refresh - RKE2 Instructions #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ements, and rephrasing with RKE2 terminology and support matrix. Signed-off-by: Sunil Singh <[email protected]>
Signed-off-by: Sunil Singh <[email protected]>
… in Rancher and rephrasing steps with new UI fields. Signed-off-by: Sunil Singh <[email protected]>
…s on registering master and worker nodes for Linux/Windows. Added note for Windows worker that Linux etcd, controlplane, and worker roles must be active to display Windows worker registration command. Signed-off-by: Sunil Singh <[email protected]>
Signed-off-by: Sunil Singh <[email protected]>
sunilarjun
requested review from
LucasSaintarbor,
btat and
martyav
as code owners
martyav
suggested changes
May 28, 2024
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Sunil Singh <[email protected]>
martyav
suggested changes
May 28, 2024
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
btat
requested changes
May 28, 2024
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
…ersioning. Signed-off-by: Sunil Singh <[email protected]>
martyav
suggested changes
Jun 24, 2024
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
...ser-guides/kubernetes-clusters-in-rancher-setup/use-windows-clusters/use-windows-clusters.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Sunil Singh <[email protected]>
|
Thanks for the edits @martyav ! Just applied the changes. |
martyav
approved these changes
Jun 27, 2024
Signed-off-by: Sunil Singh <[email protected]>
Signed-off-by: Sunil Singh <[email protected]>
|
@btat Hello Billy, would you be able to re-review this PR when you have a spare moment, many thanks! |
btat
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1074
This PR refreshes the “Launching Kubernetes on Windows Clusters” page with updated UI instructions across section headers and steps with respect to RKE2 as RKE1 Windows clusters are EOL. The available CNI’s have also been updated and have been confirmed through the Rancher Discuss channel with engineering as well as confirmed in the RKE2 documentation. The original issue was used as a basis for the refresh and lists out section updates which could be helpful when reviewing.