-
Notifications
You must be signed in to change notification settings - Fork 256
Add firewall configuration requirements for Rancher and Rancher-managed clusters #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR. Can you also copy the content under the versioned docs for supported Rancher versions? https://github.com/rancher/rancher-docs/tree/main/versioned_docs/version-2.12/how-to-guides/advanced-user-guides And update he sidebars under https://github.com/rancher/rancher-docs/tree/main/versioned_sidebars. |
6d9c443
to
acf59f9
Compare
@pmkovar thank you for looking into it. I have updated the versioned_docs and respective sidebards... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments. Overall I feel more research is needed into what exact URLs need to be whitelisted AND we probably want to split Community vs. Prime-only docs.
|
||
| URL | Port | Function | | ||
|------------------------------------|------|---------------------------------------------------------------------------| | ||
| `registry.rancher.com`, `registry.suse.com` | 443 | Provide Rancher system images, system-agent installer images, and RKE2/K3s artifacts. Both URLs resolve to the same SUSE registry backend, but either may appear in manifests or image references. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe we want to actually "advertise" SUSE Prime Registry URLs in Community docs. registry.rancher.com
/registry.suse.com
values are even in secrets in our GH CI workflows.
It's not a security issue per se but also for users running Community Rancher there is no value in whitelisting these URLs.
And vice-versa if users are running Rancher Prime they don't generally need to whitelist docker.io
as all images Rancher Prime needs should be coming from Rancher Prime Registry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snasovich yeah, i want to keep this for SUSE Rancher Customer...
Can suggest me a place where i can this pr...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for posterity answered in DM
| URL | Port | Function | | ||
|------------------------------------|------|---------------------------------------------------------------------------| | ||
| `registry.rancher.com`, `registry.suse.com` | 443 | Provide Rancher system images, system-agent installer images, and RKE2/K3s artifacts. Both URLs resolve to the same SUSE registry backend, but either may appear in manifests or image references. | | ||
| `*.suse.com` | 443 | Provides dynamic content and installation bundles required during RKE2/K3s provisioning | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you point to examples of these? May want to be more specific than *.suse.com
here.
| `registry.rancher.com`, `registry.suse.com` | 443 | Provide Rancher system images, system-agent installer images, and RKE2/K3s artifacts. Both URLs resolve to the same SUSE registry backend, but either may appear in manifests or image references. | | ||
| `*.suse.com` | 443 | Provides dynamic content and installation bundles required during RKE2/K3s provisioning | | ||
| `docker.io` | 443 | Provides community container images used by optional Rancher features | | ||
| `ghcr.io` | 443 | Provides Rancher dependencies stored in the GitHub Container Registry | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious what dependencies are we using from ghcr.io directly? I was under the impression necessary images are mirrored to DockerHub's rancher
org and SUSE Rancher Prime Registry for community/Prime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #1849
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.
Description
Add allow-list to firewall configuration requirements for Rancher and Rancher-managed clusters
Comments