bump go version to 1.25 #382
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs rebase |
Signed-off-by: Khwaja Faraz Ahmed <[email protected]>
farazkhawaja
force-pushed
the
bump-go125
branch
from
6b6ce6a to
a7b9564
Compare
|
it looks like some modules will need updates to work with go 1.25 |
Signed-off-by: Khwaja Faraz Ahmed <[email protected]>
|
I think you may need to also run |
Signed-off-by: Khwaja Faraz Ahmed <[email protected]>
|
@brandond did the CI timeout? |
|
There are regressions (golang/go#75828) in the most recent upstream golang patch releases, we're going to wait for those to be addressed and then we can update again. |
farazkhawaja
commented
Oct 14, 2025
| module github.com/rancher/system-upgrade-controller | ||
|
|
||
| go 1.24.6 | ||
| go 1.25.0 |
There was a problem hiding this comment.
@brandond go 1.25.3 just released. should i change this line from go 1.25.0 to go 1.25.3 . toolchain needs to be changed aswell right?
There was a problem hiding this comment.
The bci/golang:1.25 hardcodes GOTOOLCHAIN env var to whatever patch version is in the image. That said, the new patch release isn't available from BCI yet:
brandond@dev01:~$ docker run registry.suse.com/bci/golang:1.25 go version
go version go1.25.2 linux/amd64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades go version to 1.25
ran go mod tidy on suc/ and suc/pkg/apis folder