This repository was archived by the owner on Mar 25, 2024. It is now read-only.
Remove “replace” for client-go dependency #1177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream prometheus-operator formerly had a corresponding “replace” directive, requiring rancher/types and all dependent repositories to do the same. As of prometheus-operator 0.41.0, this is no longer the case.
|
can this be merged. We have problem with `go list -m all > go.list go list -m: k8s.io/[email protected]+incompatible: invalid version: +incompatible suffix not allowed: module contains a go.mod file, so semantic import versioning is required` |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream prometheus-operator formerly had a corresponding “replace”
directive, requiring rancher/types and all dependent repositories to do
the same. As of prometheus-operator 0.41.0, this is no longer the case.
Updates other deps to be consistent with each other.