Skip to content

Cast inputs to true division from decimal to float #20077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: branch-25.12
Choose a base branch
from
Open

Cast inputs to true division from decimal to float #20077

wants to merge 4 commits into from

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Sep 23, 2025 •
edited
Loading

Description

Closes #19972. Decimal support for TRUE_DIV is not in scope for libcudf. So we do the next best thing and cast the inputs to float ahead of time.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 requested a review from a team as a code owner September 23, 2025 15:55
@Matt711 Matt711 added bug Something isn't working non-breaking Non-breaking change labels Sep 23, 2025
@github-actions github-actions bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels Sep 23, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Sep 23, 2025
Matt711
Matt711 commented Sep 23, 2025
View reviewed changes
python/cudf_polars/tests/expressions/test_numeric_binops.py
assert_gpu_result_equal(q)


def test_true_div_with_decimals():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Don't check output dtype for polars version < 1.32 because of #19975

@Matt711
Copy link
Contributor Author

Matt711 commented Sep 25, 2025

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@TomAugspurger TomAugspurger Awaiting requested review from TomAugspurger TomAugspurger is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@rjzamora rjzamora Awaiting requested review from rjzamora rjzamora is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
bug Something isn't working cudf-polars Issues specific to cudf-polars non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt711 @mroeschke