Rework reduction case statement as dispatch_type_and_aggregation #20078
+523
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
davidwendt
commented
Sep 23, 2025
| // default column_view{} is an empty column | ||
| // empty column_view | ||
| CUDF_EXPECT_NO_THROW(statement(cudf::column_view{})); | ||
|
|
There was a problem hiding this comment.
This was an invalid test -- libcudf type-dispatcher is designed to throw on an invalid or empty type.
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
davidwendt
added
3 - Ready for Review
|
/ok to test |
bdice
approved these changes
Sep 29, 2025
ttnghia
approved these changes
Sep 29, 2025
|
/merge |
rapids-bot
bot
merged commit 0c8f9cb
into
rapidsai:branch-25.12
252 of 254 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworks the switch/case statement in reductions.cpp to use
dispatch_type_and_aggregationinstead.This allows the specific functors to indicate valid aggregation/type support, reduce behavior when no data is given, as well as the reduction function itself. This makes it easier to update existing aggregations and support newer ones more reliably. It also allows for a reduction-specific
is_valid_aggregation()API by keeping making the valid checks a compile-time feature.Checklist