Deprecate legacy public row operators #20097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
libcudf
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test fa598b6 |
|
/ok to test d4377b9 |
ttnghia
added a commit
to NVIDIA/spark-rapids-jni
that referenced
this pull request
Sep 27, 2025
…ators (#3783) The cudf's experimental row operators are going to be removed in rapidsai/cudf#20097. As such, we also need to adopt such changes. We just need to switch to use the `cudf::detail::` row operators which were already implemented to be the same as the deprecated `cudf::experimental::` ones. --------- Signed-off-by: Nghia Truong <[email protected]>
|
/ok to test e0ba2c4 |
PointKernel
added
3 - Ready for Review
PointKernel
commented
Sep 29, 2025
bdice
approved these changes
Sep 29, 2025
ttnghia
approved these changes
Sep 29, 2025
davidwendt
approved these changes
Sep 29, 2025
lamarrr
approved these changes
Oct 1, 2025
|
/merge |
rapids-bot
bot
merged commit c2c1873
into
rapidsai:branch-25.12
130 of 132 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #19191
This PR deprecates the legacy row operators and relocates their tests to a dedicated folder. It also includes several fixes identified while removing the old headers.
Checklist