Make Column.set_mask go through pylibcudf #20103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
improvement
vyasr
reviewed
Sep 26, 2025
| else: | ||
| new_mask = None | ||
| new_null_count = 0 | ||
| exposed = isinstance(self.data, ExposureTrackedBuffer) |
There was a problem hiding this comment.
I'm afraid I don't remember the exact semantics of the buffer classes right now to be sure, but is this condition not too broad? Can't you have an ExposureTrackedBuffer that is not currently exposed? I don't think the current code will result in incorrect results in any case, it might just be less efficient than ideal by forcing copies.
There was a problem hiding this comment.
Actually turns out I didn't need this condition, so it's been removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Broken off from #20087
Checklist