Skip to content

Fix arrow timestamp frequency cases in cudf.pandas #20128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

Fix arrow timestamp frequency cases in cudf.pandas #20128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a54196c
Fix arrow type datetimetz cases
galipremsagar Sep 26, 2025
f813534
Merge branch 'branch-25.12' into 19852
galipremsagar Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/cudf/cudf/core/dtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ def dtype(arbitrary: Any) -> DtypeObj:
arrow_type == pa.date32()
or arrow_type == pa.binary()
or isinstance(arrow_type, pa.DictionaryType)
) or (
cudf.get_option("mode.pandas_compatible")
and isinstance(arrow_type, pa.TimestampType)
and getattr(arrow_type, "tz", None) is not None
):
raise NotImplementedError(
f"cuDF does not yet support {pd_dtype}"
Expand Down
77 changes: 5 additions & 72 deletions python/cudf/cudf/pandas/scripts/conftest-patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2731,19 +2731,6 @@ def pytest_unconfigure(config):
"tests/extension/test_arrow.py::TestArrowArray::test_compare_array[duration[us]-le]",
"tests/extension/test_arrow.py::TestArrowArray::test_compare_array[duration[us]-lt]",
"tests/extension/test_arrow.py::TestArrowArray::test_compare_array[duration[us]-ne]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[date64[ms]]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[timestamp[ms, tz=US/Eastern]]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[timestamp[ms, tz=US/Pacific]]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[timestamp[ms, tz=UTC]]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[timestamp[ns, tz=US/Eastern]]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[timestamp[ns, tz=US/Pacific]]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[timestamp[ns, tz=UTC]]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[timestamp[s, tz=US/Eastern]]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[timestamp[s, tz=US/Pacific]]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[timestamp[s, tz=UTC]]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[timestamp[us, tz=US/Eastern]]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[timestamp[us, tz=US/Pacific]]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[timestamp[us, tz=UTC]]",
"tests/extension/test_arrow.py::TestArrowArray::test_getitem_scalar[duration[ms]]",
"tests/extension/test_arrow.py::TestArrowArray::test_getitem_scalar[duration[ms]]",
"tests/extension/test_arrow.py::TestArrowArray::test_getitem_scalar[duration[s]]",
Expand Down Expand Up @@ -2915,33 +2902,6 @@ def pytest_unconfigure(config):
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor[uint32]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor[uint64]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor[uint8]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[date64[ms]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[timestamp[ms, tz=US/Eastern]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[timestamp[ms, tz=US/Pacific]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[timestamp[ms, tz=UTC]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[timestamp[ns, tz=US/Eastern]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[timestamp[ns, tz=US/Pacific]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[timestamp[ns, tz=UTC]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[timestamp[s, tz=US/Eastern]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[timestamp[s, tz=US/Pacific]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[timestamp[s, tz=UTC]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[timestamp[us, tz=US/Eastern]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[timestamp[us, tz=US/Pacific]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[timestamp[us, tz=UTC]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[date64[ms]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[timestamp[ms, tz=US/Eastern]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[timestamp[ms, tz=US/Pacific]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[timestamp[ms, tz=UTC]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[timestamp[ns, tz=US/Eastern]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[timestamp[ns, tz=US/Pacific]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[timestamp[ns, tz=UTC]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[timestamp[s, tz=US/Eastern]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[timestamp[s, tz=US/Pacific]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[timestamp[s, tz=UTC]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[timestamp[us, tz=US/Eastern]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[timestamp[us, tz=US/Pacific]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[timestamp[us, tz=UTC]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_with_index[date64[ms]]",
"tests/extension/test_arrow.py::TestArrowArray::test_setitem_2d_values[duration[ms]]",
"tests/extension/test_arrow.py::TestArrowArray::test_setitem_2d_values[duration[ns]]",
"tests/extension/test_arrow.py::TestArrowArray::test_setitem_2d_values[duration[s]]",
Expand Down Expand Up @@ -3084,18 +3044,6 @@ def pytest_unconfigure(config):
"tests/extension/test_arrow.py::test_boolean_reduce_series_all_null[all-False]",
"tests/extension/test_arrow.py::test_boolean_reduce_series_all_null[any-False]",
"tests/extension/test_arrow.py::test_comparison_not_propagating_arrow_error",
"tests/extension/test_arrow.py::test_describe_datetime_data[pa_type10]",
"tests/extension/test_arrow.py::test_describe_datetime_data[pa_type11]",
"tests/extension/test_arrow.py::test_describe_datetime_data[pa_type13]",
"tests/extension/test_arrow.py::test_describe_datetime_data[pa_type14]",
"tests/extension/test_arrow.py::test_describe_datetime_data[pa_type15]",
"tests/extension/test_arrow.py::test_describe_datetime_data[pa_type1]",
"tests/extension/test_arrow.py::test_describe_datetime_data[pa_type2]",
"tests/extension/test_arrow.py::test_describe_datetime_data[pa_type3]",
"tests/extension/test_arrow.py::test_describe_datetime_data[pa_type5]",
"tests/extension/test_arrow.py::test_describe_datetime_data[pa_type6]",
"tests/extension/test_arrow.py::test_describe_datetime_data[pa_type7]",
"tests/extension/test_arrow.py::test_describe_datetime_data[pa_type9]",
"tests/extension/test_arrow.py::test_dt_day_month_name[day_name-Sunday]",
"tests/extension/test_arrow.py::test_dt_day_month_name[month_name-January]",
"tests/extension/test_arrow.py::test_dt_days_in_month[days_in_month]",
Expand All @@ -3120,11 +3068,6 @@ def pytest_unconfigure(config):
"tests/extension/test_arrow.py::test_dt_strftime",
"tests/extension/test_arrow.py::test_dt_to_pydatetime",
"tests/extension/test_arrow.py::test_dt_to_pytimedelta",
"tests/extension/test_arrow.py::test_dt_tz[US/Pacific]",
"tests/extension/test_arrow.py::test_dt_tz[UTC]",
"tests/extension/test_arrow.py::test_dt_tz_convert[ns]",
"tests/extension/test_arrow.py::test_dt_tz_convert[us]",
"tests/extension/test_arrow.py::test_dt_tz_convert_none",
"tests/extension/test_arrow.py::test_dt_tz_localize_nonexistent[shift_backward-exp_date1]",
"tests/extension/test_arrow.py::test_duration_overflow_from_ndarray_containing_nat",
"tests/extension/test_arrow.py::test_from_arrow_respecting_given_dtype",
Expand Down Expand Up @@ -3158,19 +3101,6 @@ def pytest_unconfigure(config):
"tests/extension/test_arrow.py::test_interpolate_not_numeric[timestamp[ns]]",
"tests/extension/test_arrow.py::test_interpolate_not_numeric[timestamp[s]]",
"tests/extension/test_arrow.py::test_interpolate_not_numeric[timestamp[us]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[date64[ms]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[timestamp[ms, tz=US/Eastern]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[timestamp[ms, tz=US/Pacific]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[timestamp[ms, tz=UTC]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[timestamp[ns, tz=US/Eastern]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[timestamp[ns, tz=US/Pacific]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[timestamp[ns, tz=UTC]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[timestamp[s, tz=US/Eastern]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[timestamp[s, tz=US/Pacific]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[timestamp[s, tz=UTC]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[timestamp[us, tz=US/Eastern]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[timestamp[us, tz=US/Pacific]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[timestamp[us, tz=UTC]]",
"tests/extension/test_arrow.py::test_pickle_roundtrip[decimal128(7, 3)]",
"tests/extension/test_arrow.py::test_pow_missing_operand",
"tests/extension/test_arrow.py::test_quantile[bool-0.5-higher]",
Expand Down Expand Up @@ -8400,8 +8330,6 @@ def pytest_unconfigure(config):
"tests/indexing/test_scalar.py::TestScalar::test_iat_set_ints[ints-series]",
"tests/indexing/test_scalar.py::TestScalar::test_iat_set_ints[uints-series]",
"tests/interchange/test_impl.py::test_multi_chunk_column",
"tests/interchange/test_impl.py::test_pandas_nullable_with_missing_values[data14-timestamp[us, Asia/Kathmandu][pyarrow]-timestamp[us, tz=Asia/Kathmandu]]",
"tests/interchange/test_impl.py::test_pandas_nullable_without_missing_values[data14-timestamp[us, Asia/Kathmandu][pyarrow]-timestamp[us, tz=Asia/Kathmandu]]",
"tests/interchange/test_impl.py::test_string_validity_buffer",
"tests/interchange/test_impl.py::test_string_validity_buffer_no_missing",
"tests/io/excel/test_odswriter.py::test_cell_value_type[1-float-value-1]",
Expand Down Expand Up @@ -12728,6 +12656,11 @@ def pytest_unconfigure(config):
"tests/generic/test_finalize.py::test_categorical_accessor[method4]",
"tests/generic/test_finalize.py::test_categorical_accessor[method7]",
"tests/generic/test_finalize.py::test_categorical_accessor[method8]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_no_data_with_index[date64[ms]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_na_with_index[date64[ms]]",
"tests/extension/test_arrow.py::TestArrowArray::test_series_constructor_scalar_with_index[date64[ms]]",
"tests/extension/test_arrow.py::TestArrowArray::test_construct_empty_dataframe[date64[ms]]",
"tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[date64[ms]]",
"tests/extension/test_arrow.py::TestArrowArray::test_reduce_series_numeric[uint8-skew-True]",
"tests/extension/test_arrow.py::TestArrowArray::test_reduce_series_numeric[uint16-skew-True]",
"tests/extension/test_arrow.py::TestArrowArray::test_reduce_series_numeric[uint32-skew-True]",
Expand Down