-
Notifications
You must be signed in to change notification settings - Fork 978
Fix type annotations in cudf-polars #20131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 3 commits into
rapidsai:branch-25.12
from
TomAugspurger:tom/cudf-polars-type-fixes
Sep 30, 2025
Merged
Fix type annotations in cudf-polars #20131
rapids-bot
merged 3 commits into
rapidsai:branch-25.12
from
TomAugspurger:tom/cudf-polars-type-fixes
Sep 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a handful of type annotations in cudf-polars that are missed because we don't have some dependencies in the type checker's environment (e.g. polars).
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test 7cfce3f |
TomAugspurger
commented
Sep 29, 2025
mroeschke
reviewed
Sep 29, 2025
mroeschke
approved these changes
Sep 29, 2025
Matt711
reviewed
Sep 29, 2025
Matt711
approved these changes
Sep 30, 2025
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cudf-polars
Issues specific to cudf-polars
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a handful of type annotations in cudf-polars that are missed because we don't have some dependencies in the type checker's environment (e.g. polars). Running with those packages turned up a few (mostly harmless) issues.