Disable async MR priming in cudf.pandas #20133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
4 tasks
mroeschke
added
improvement
mroeschke
approved these changes
Sep 29, 2025
Contributor
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
I marked as "breaking" but feel free to change that label if you feel otherwise
galipremsagar
approved these changes
Sep 29, 2025
bdice
added
non-breaking
Contributor
Author
|
Thanks for adding labels @mroeschke. I think this should be pretty minor - no performance impact expected, and no API changes. I'll mark as |
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes cudf.pandas portion of rapidsai/rmm#2060.
We should not prime the async MR by default.
Checklist