Add memory resources to reduce, column, column_factories, and contiguous_split #20135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional DeviceMemoryResource parameters to reduce, scan, and minmax functions in pylibcudf.reduce module. Note that scalar-returning functions (reduce, minmax) maintain the API consistency but scalars use their own memory allocation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Implement DeviceMemoryResource parameters for all 6 column factory functions: - make_empty_column - make_numeric_column - make_fixed_point_column - make_timestamp_column - make_duration_column - make_fixed_width_column Updated .pyx, .pxd, and .pyi files following established pattern. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Updates column.pyx, column.pxd, and column.pyi to support DeviceMemoryResource parameters for functions that create new columns: - from_scalar: Create column from scalar value - all_null_like: Create null column with same properties - copy: Deep copy of column 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add DeviceMemoryResource parameter to unpack() function - Add DeviceMemoryResource parameter to unpack_from_memoryviews() function - Update TableWithMetadata.from_libcudf calls to pass memory resource - Ensure proper memory resource handling for serialization operations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This commit addresses critical inconsistencies between C++ headers and Cython bindings that were found during systematic verification: - column_factories.pxd: Remove incorrect stream/mr parameters from make_empty_column declarations to match C++ API (these functions don't accept these parameters in libcudf) - column_factories.pyx: Remove corresponding incorrect parameters from make_empty_column function calls - contiguous_split.pxd: Add missing stream/mr parameters to pack and contiguous_split function declarations - contiguous_split.pyx: Add missing DeviceMemoryResource parameter to pack function signature and fix C++ call - column.pyx: Fix make_column_from_scalar calls to include missing mr.get_mr() parameter (was causing compilation errors) - reduce.pxd: Add missing reduce function overload with init parameter All changes ensure Cython bindings correctly expose the underlying C++ APIs with proper DeviceMemoryResource parameter forwarding. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- contiguous_split.pyx: Remove unused mr parameter from unpack function - reduce: Add optional init parameter with conditional C++ overload calls 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
github-actions
bot
added
Python
bdice
approved these changes
Sep 29, 2025
|
/merge |
1 similar comment
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #15170
Checklist