-
Notifications
You must be signed in to change notification settings - Fork 976
Adjust rmm pool handling in PDSH benchmarks #20138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust rmm pool handling in PDSH benchmarks #20138
Conversation
This updates the handling of the RMM Pool argument for the PDSH CLI. Previously, `--rmm-pool-size` was used for both sync and async RMM memory resources. As described in rapidsai/rmm#2060, the meaning of the pool size is different for these two types of memory resources, and rapidsai/dask-cuda#1563 is deprecating passing a pool size to `dask_cuda.LocalCUDACluster` with `rmm_async=True`.
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tom! Any reason this is marked as Draft? Seems like this should go in before rapidsai/dask-cuda#1563, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me -- can you help advise on #20129?
/merge |
Description
This updates the handling of the RMM Pool argument for the PDSH CLI. Previously,
--rmm-pool-size
was used for both sync and async RMM memory resources.As described in rapidsai/rmm#2060, the meaning of the pool size is different for these two types of memory resources, and rapidsai/dask-cuda#1563 is deprecating passing a pool size to
dask_cuda.LocalCUDACluster
withrmm_async=True
.No real difference in the timings (maybe a small improvement, but more likely just noise):