Skip to content

Conversation

TomAugspurger
Copy link
Contributor

Description

This updates the handling of the RMM Pool argument for the PDSH CLI. Previously, --rmm-pool-size was used for both sync and async RMM memory resources.

As described in rapidsai/rmm#2060, the meaning of the pool size is different for these two types of memory resources, and rapidsai/dask-cuda#1563 is deprecating passing a pool size to dask_cuda.LocalCUDACluster with rmm_async=True.

No real difference in the timings (maybe a small improvement, but more likely just noise):

# New default
python python/cudf_polars/cudf_polars/experimental/benchmarks/pdsh.py --path /datasets/toaugspurger/tpch/scale-100/ --no-print-results  --executor streaming --scheduler distributed --iterations 3 --rmm-async 1,2,3,4,5
# Total mean time across all queries: 45.6239 seconds

# Previous default
python python/cudf_polars/cudf_polars/experimental/benchmarks/pdsh.py --path /datasets/toaugspurger/tpch/scale-100/ --no-print-results  --executor streaming --scheduler distributed --iterations 3 --rmm-async --rmm-pool-size 0.5 1,2,3,4,5
# Total mean time across all queries: 47.8799 seconds

This updates the handling of the RMM Pool argument for the PDSH CLI.
Previously, `--rmm-pool-size` was used for both sync and async RMM
memory resources.

As described in rapidsai/rmm#2060, the meaning
of the pool size is different for these two types of memory resources,
and rapidsai/dask-cuda#1563 is deprecating
passing a pool size to `dask_cuda.LocalCUDACluster` with
`rmm_async=True`.
Copy link

copy-pr-bot bot commented Sep 29, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels Sep 29, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Sep 29, 2025
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tom! Any reason this is marked as Draft? Seems like this should go in before rapidsai/dask-cuda#1563, correct?

@TomAugspurger TomAugspurger marked this pull request as ready for review September 29, 2025 21:21
@TomAugspurger TomAugspurger requested a review from a team as a code owner September 29, 2025 21:21
@TomAugspurger TomAugspurger added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 29, 2025
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me -- can you help advise on #20129?

@TomAugspurger
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c2283f7 into rapidsai:branch-25.12 Oct 3, 2025
130 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Oct 3, 2025
@TomAugspurger TomAugspurger deleted the tom/rmm-async-pool-size branch October 3, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf-polars Issues specific to cudf-polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants