[CI][precommit] Fix instruction command in validate helm hook #3747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LeoLiao123 <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Fixes the error message in the Helm validation script to point to the correct pre-commit command.
- Correct the typo in the hook name and add the missing
runsubcommand in the instructions. - Ensures users are directed to
pre-commit run generate-crd-schema --all-files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
If following the original instructions in
scripts/validate-helm.sh, cannot correctly execute thegenerate-crd-schemahook.Related issue number
None
Manual test
Checks