[Test][Autoscaler] add fake single-host TPU tests #3792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidxia
force-pushed
the
patch16
branch
2 times, most recently
from
b4a05b4 to
c79e3f5
Compare
Modify create_detached_actor.py to easily parse CLI custom resources as key=value pairs. contributes to ray-project#2173 Signed-off-by: David Xia <[email protected]>
davidxia
changed the title
davidxia
commented
Jun 18, 2025
| LogWithTimestamp(test.T(), "Updated RayCluster %s/%s successfully", rayCluster.Namespace, rayCluster.Name) | ||
|
|
||
| // Validate that the TPU slice is scaled down. | ||
| g.Eventually(WorkerPods(test, rayCluster), TestTimeoutMedium).Should(gomega.BeEmpty()) |
Collaborator
Author
There was a problem hiding this comment.
fails because there's still 1 Pod and not scaled to 0. Any ideas?
Collaborator
Author
|
ray-project/ray@c2cf471 from ray-project/ray#53938 is in Ray since 2.48.0. So this PR is waiting on the next upgrade of the default Ray in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
create_detached_actor.pyto easily parse CLI custom resources as key=value pairs.contributes to #2173
depends on ray-project/ray#53938
Checks