Add a test util function for killing the head Pod and wait

[owenowenisme]

Why are these changes needed?

Closes #3889

Related issue number

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • This PR is not tested :(

[owenowenisme]

@rueian PTAL

[400Ping]

LGTM

[AndySung320]

Hi, I'm still learning the codebase, but would it be cleaner to pass the Gomega instance as a parameter rather than creating a new one inside the function? This way we avoid duplicate NewWithT(test.T()) calls and use the same instance as the caller. Let me know if I'm missing something!

[win5923]

Please remove one of them to avoid confusion.

[win5923]

LGTM, thanks!

[win5923]

Thanks for fixing it. It's my bad..

[owenowenisme]

Hi, I'm still learning the codebase, but would it be cleaner to pass the Gomega instance as a parameter rather than creating a new one inside the function? This way we avoid duplicate NewWithT(test.T()) calls and use the same instance as the caller. Let me know if I'm missing something!

@AndySung320
You're right, we could avoid duplicate if we pass gomega instance, but I think we might have other test that doesn't use gomega so usingNewWithT(test.T()) inside will allow them to pass test without creating gomega in their test func.

And since this is only for testing purpose duplicate Gomega instance is acceptable IMO.

Thanks for commenting!