[deps] remove time series and ludwig dependencies #54316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not used anywhere Signed-off-by: Lonnie Liu <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused conditional blocks for installing Ludwig and time series libraries in the CI environment setup.
- Deleted the
INSTALL_LUDWIGblock that added Ludwig and jsonschema packages. - Deleted the
INSTALL_TIMESERIES_LIBSblock that added statsforecast, prophet, and holidays.
Comments suppressed due to low confidence (2)
ci/env/install-dependencies.sh:277
- Since the Ludwig installation block has been removed, consider cleaning up any related environment variable definitions (e.g., INSTALL_LUDWIG and INSTALL_TIMESERIES_LIBS) in CI configuration files or scripts to avoid confusion.
fi
ci/env/install-dependencies.sh:277
- Please update any related README or CI documentation to remove references to INSTALL_LUDWIG and INSTALL_TIMESERIES_LIBS flags, ensuring docs stay in sync with the code.
fi
elliot-barn
approved these changes
Jul 7, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jul 7, 2025
not used anywhere Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: elliot-barn <[email protected]>
ccmao1130
pushed a commit
to ccmao1130/ray
that referenced
this pull request
Jul 29, 2025
not used anywhere Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: ChanChan Mao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not used anywhere